Fix avifDecSampleTransformItemValidateProperties()#3013
Open
y-guyon wants to merge 1 commit intoAOMediaCodec:mainfrom
Open
Fix avifDecSampleTransformItemValidateProperties()#3013y-guyon wants to merge 1 commit intoAOMediaCodec:mainfrom
y-guyon wants to merge 1 commit intoAOMediaCodec:mainfrom
Conversation
Collaborator
|
Yannis: I tried to review this PR last week, but the PR is a little long, so I didn't finish the review. Could you please rebase the PR and resolve the conflicts? Thanks. |
y-guyon
force-pushed
the
satogrid
branch
2 times, most recently
from
b5ebee2 to
511dddf
Compare
Contributor
Author
Done. Thanks for taking a look! |
Collaborator
|
Yannis: There is a merge error. The new commit has the wrong commit message: |
Return BMFF_PARSE_FAILED intead of INTERNAL_ERROR on missing ispe. Implement TODO about verifying av1C consistency. Fix comment wrongly referring to item being a grid instead of a sato. Also add an extra check in avifPropertyArrayFind().
Contributor
Author
Good catch. I wonder how I messed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return BMFF_PARSE_FAILED intead of INTERNAL_ERROR on missing ispe.
Implement TODO about verifying av1C consistency.
Fix comment wrongly referring to item being a grid instead of a sato.
Also add an extra check in avifPropertyArrayFind().