Add build command lines to README.md #1924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They should work for both Windows and Unix environments. [skip-ci]
kmilos
reviewed
Jan 11, 2024
Co-authored-by: Miloš Komarčević <4973094+kmilos@users.noreply.github.com>
[skip-ci] Co-authored-by: Miloš Komarčević <4973094+kmilos@users.noreply.github.com>
vrabaud
approved these changes
Jan 11, 2024
wantehchang
reviewed
Jan 13, 2024
Collaborator
wantehchang
left a comment
wantehchang
left a comment
There was a problem hiding this comment.
LGTM. Thanks for adding the build instructions.
|
|
||
| #### Build using installed dependencies | ||
|
|
||
| To link against the already installed `aom`, `libjpeg` and `libpng` dependency |
Collaborator
There was a problem hiding this comment.
I suggest also adding the libsharpyuv-dev package: https://packages.debian.org/search?keywords=libsharpyuv-dev
I wrote #1937 to add libsharpyuv to the "Build everything from scratch" section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They should work for both Windows and Unix environments.
(#1920 made me realize there were no actual build instructions provided in README.md)