Skip to content

added ability to save JSON as secrete values#3

Open
gregkeys wants to merge 1 commit intoAMeng:masterfrom
gregkeys:master
Open

added ability to save JSON as secrete values#3
gregkeys wants to merge 1 commit intoAMeng:masterfrom
gregkeys:master

Conversation

@gregkeys
Copy link

This adds the ability to read and save Json values stored in vault

@AMeng
Copy link
Owner

AMeng commented Sep 19, 2016

Thanks for the PR. Can you explain this a bit more? Are you not currently able to save JSON values?

@gregkeys
Copy link
Author

without this PR json looks like [Object Object] and if you save that it
will replace the json values

On Sep 19, 2016 8:58 AM, "Alex Meng" notifications@github.com wrote:

Thanks for the PR. Can you explain this a bit more? Are you not currently
able to save JSON values?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#3 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADIV-ydraXa6SeE6zKE58hZy8ggw5Ariks5qrrEigaJpZM4KAI4E
.

@AMeng
Copy link
Owner

AMeng commented Sep 19, 2016

I'm not able to reproduce the bug. Can you provide example values that cause this? When I enter a JSON string into the value of a secret, it saves and loads fine.

image

Or am I misunderstanding the issue?

@gregkeys
Copy link
Author

gregkeys commented Sep 19, 2016

when we first implemented your ui our values came from the command line
perhaps that was part of the problem, vault write secret/foo
bar='{"one":"two"}'

also try this {"one":"two"} with the quotes

On Sep 19, 2016 1:39 PM, "Alex Meng" notifications@github.com wrote:

I'm not able to reproduce the bug. Can you provide example values that
cause this? When I enter a JSON string into the value of a secret, it saves
and loads fine.

[image: image]
https://cloud.githubusercontent.com/assets/192336/18648063/28db0b0a-7e76-11e6-9556-c841b21db6a0.png

Or am I misunderstanding the issue?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#3 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADIV--5S2_kXOL9AwRiKYFaYGIzHWqZtks5qrvMcgaJpZM4KAI4E
.

@AMeng
Copy link
Owner

AMeng commented Sep 20, 2016

I'm still not able to reproduce this. I tried all the values you suggested from both the UI and the CLI. Is there any way you can provide a more complete example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants