Skip to content

CI: Set random seed in flaky test_jax.py::test_conversion and test_sbml_import.py::test_likelihoods #3132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dweindl merged 2 commits into from
Feb 25, 2026
Merged

CI: Set random seed in flaky test_jax.py::test_conversion and test_sbml_import.py::test_likelihoods #3132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6da5bb
CI: Set random seed in flaky python/tests/test_jax.py::test_conversion
dweindl Feb 25, 2026
b899d54
test_likelihoods
dweindl Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/tests/test_jax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def _test_model(amici_module, jax_module, ts, p, k):

amici_model.set_free_parameters(np.asarray(p, dtype=np.float64))
amici_model.set_fixed_parameters(np.asarray(k, dtype=np.float64))
edata = ExpData(sol_amici_ref, 1.0, 1.0)
edata = ExpData(sol_amici_ref, 1.0, 1.0, 1)
edata.free_parameters = amici_model.get_free_parameters()
edata.fixed_parameters = amici_model.get_fixed_parameters()
edata.pscale = amici_model.get_parameter_scale()
Expand Down
4 changes: 2 additions & 2 deletions python/tests/test_sbml_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,10 +558,10 @@ def test_likelihoods(model_test_likelihoods):

rdata = model.simulate(solver=solver)
sigmas = rdata["y"].max(axis=0) * 0.05
edata = ExpData(rdata, sigmas, [])
edata = ExpData(rdata, sigmas, [], 1)
# just make all observables positive since some are logarithmic
while min(edata.get_measurements()) < 0:
edata = ExpData(rdata, sigmas, [])
edata = ExpData(rdata, sigmas, [], 1)

# and now run for real and also compute likelihood values
rdata = model.simulate(solver=solver, edata=[edata])[0]
Expand Down
Loading