JSON support in MemoryAnalysis handler #26
Merged
coleramos425 merged 4 commits intomainfrom Jul 11, 2025
Merged
Conversation
Collaborator
Author
|
Most recent commit finalizes this PR by ensuring valid JSON syntax when producing a MemoryAnalysis report for an application with several dispatches The core challenge is creating a mechanism that can reliably signal when all processing is complete, allowing for final JSON output refinement without disrupting the existing plugin architecture. Implementing this logic in the omniprobe module seems to be the simplest solution |
Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
…ess for proper JSON formatting Signed-off-by: coleramos425 <colramos@amd.com>
…patch report, implemented a mechanizm in omniprobe to *close report*. This way we're certain we're done writing dispatches Signed-off-by: coleramos425 <colramos@amd.com>
71a9d32 to
bf408bb
Compare
This was referenced Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an iteration on #21 that instead logs MemoryAnalysis output in the logduration message handler. The plugin behaves same as before in most instances, however now when user provides
-t jsonJSON output will print to console. Additionally, the user can specify a log file (e.g.-l output.json) to save this JSON structure to an output file for further post-processing.Example usage: