Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds a starter implementation for integrating the rocprofiler-sdk into the Omniprobe interceptor by registering callbacks and updating the build.
- Introduces SDK headers and implements initialization, finalization, and API registration callbacks in
interceptor.cc. - Updates CMakeLists to find and link against the
rocprofiler-sdkpackage.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/interceptor.cc | Adds rocp_sdk_tool_init, rocp_sdk_tool_fini, and registration logic |
| src/CMakeLists.txt | Adds find_package(rocprofiler-sdk) and links rocprofiler-sdk::rocprofiler-sdk |
Comments suppressed due to low confidence (2)
src/interceptor.cc:1005
- [nitpick] The callback name
rocp_sdk_api_registration_callbackis generic. A more descriptive name (e.g.on_hsa_table_registration) would improve readability.
void
src/CMakeLists.txt:52
- [nitpick] It may be helpful to update the project README or
docs/to document the newrocprofiler-sdkdependency and any required installation steps.
find_package(rocprofiler-sdk REQUIRED)
- includes and missing return value
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was reviewing some Omniprobe code and provided a "starter" implementation of using rocprofiler-sdk. I didn't check if it compiled so may have missed something minor