Skip to content

pldm: Sensor polling after setting numeric effecter#70

Open
spargaon wants to merge 1 commit into
integ_sp8from
fwdevel-185095-polling-review
Open

pldm: Sensor polling after setting numeric effecter#70
spargaon wants to merge 1 commit into
integ_sp8from
fwdevel-185095-polling-review

Conversation

@spargaon
Copy link
Copy Markdown
Collaborator

Polling for value of a numeric sensor that has a
corrospoinding numeric effecter is disabled since
the polling returns error until the numeric effecter is set to an pertinent value.

Once a numeric effecter is set with a pertinent value using D-Bus set-property method, enable polling the corresponding numeric sensor for its value.

@spargaon
Copy link
Copy Markdown
Collaborator Author

@spargaon
Copy link
Copy Markdown
Collaborator Author

Once a numeric effecter is set, sensor polling that was disabled when pldmd started, is enabled.
root@congo-0555:# busctl get-property xyz.openbmc_project.PLDM /xyz/openbmc_project/sensors/frequency/Processor0_ReadBIOSBoostFMax xyz.openbmc_project.Sensor.Value Value
d 0
root@congo-0555:
# busctl set-property xyz.openbmc_project.PLDM /xyz/openbmc_project/controls/Processor0_ReadBIOSBoostFmax xyz.openbmc_project.Control.NumericEffecter EffecterValue ay 4 1 1 1 1
root@congo-0555:# busctl get-property xyz.openbmc_project.PLDM /xyz/openbmc_project/sensors/frequency/Processor0_ReadBIOSBoostFMax xyz.openbmc_project.Sensor.Value Value
d 0
root@congo-0555:
# busctl get-property xyz.openbmc_project.PLDM /xyz/openbmc_project/sensors/frequency/Processor0_ReadBIOSBoostFMax xyz.openbmc_project.Sensor.Value Value
d nan

This message is logged and polling starts.

<6> Enable polling for sensor ID: 8

Tx: 86 02 11 08 00 00
Rx: 06 02 11 02

Copy link
Copy Markdown
Collaborator

@mahkurap mahkurap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this AMD flag.

Polling for value of a numeric sensor that has a
corrospoinding numeric effecter is disabled since
the polling returns error until the numeric effecter
is set to an pertinent value.

Once a numeric effecter is set with a pertinent value
using D-Bus set-property method, enable polling the
corresponding numeric sensor for its value.

Signed-off-by: Shirish Pargaonkar <Shirish.Pargaonkar@amd.com>
@spargaon spargaon force-pushed the fwdevel-185095-polling-review branch from 200716c to 771dd0a Compare May 18, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants