fix training issue on NVIDIA GPUs #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a training issue on NVIDIA GPUs by adding null checks for the args.use_rocm_mem_info_iters parameter and correcting a malformed PYTHONPATH configuration.
Key changes:
- Added null safety checks before using
args.use_rocm_mem_info_itersin iteration membership tests - Fixed PYTHONPATH construction by removing an erroneous
$:token and reordering path components
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| primus/modules/trainer/megatron/trainer.py | Added null checks for use_rocm_mem_info_iters parameter in three locations to prevent errors when the parameter is not set |
| examples/run_pretrain.sh | Fixed PYTHONPATH construction by removing invalid $: syntax and reordering paths |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Xiaoming-AMD
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Overview
This pull request addresses several issues related to running Primus Megatron on the NVIDIA platform.
Key changes:
Required Parameter Adjustments
To run Primus-Megatron on NVIDIA GPUs, please ensure to set the following parameters when running Primus Megatron:
--use_rocm_mem_info False--use_rocm_mem_info_iters None