update llama & grok config #472
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnQinAMD
requested review from
Xiaoming-AMD,
limou102 and
wenxie-amd
as code owners
Xiaoming-AMD
approved these changes
Jan 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates training configuration parameters for LLaMA 3.1 405B and Grok1 models on MI355X hardware. The changes adjust parallelism and batch size settings that affect training behavior and resource utilization.
- Reduces tensor parallelism degree for LLaMA 3.1 405B from 8 to 1
- Increases global batch size for Grok1 (both BF16 and FP8 variants) from 128 to 512
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| examples/torchtitan/configs/MI355X/llama3.1_405B-pretrain.yaml | Reduces tensor_parallel_degree from 8 to 1, aligning with other large model configs |
| examples/megatron/configs/MI355X/grok1-FP8-pretrain.yaml | Increases global_batch_size from 128 to 512, quadrupling gradient accumulation steps |
| examples/megatron/configs/MI355X/grok1-BF16-pretrain.yaml | Increases global_batch_size from 128 to 512, quadrupling gradient accumulation steps |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update llama and grok training config