megatron: remove useless parameters from base configuration #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation The 'parallel_output' parameter is never used since it was added. Although there are many function arguments which has the same name, the parameter is itself never refered. It is preferable to drop it since Megatron-LM runtime also never refers to it. Fixes: 8f3f200 ("Primus core (AMD-AGI#3)")
takaswie
requested review from
Xiaoming-AMD,
limou102 and
wenxie-amd
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
(C.C. @hisohara)
I realized that some parameters in base configuration for Megatron-LM runtime are neither referred by Primus (including Primus-Turbo) nor Megatron-LM (
core_v0.12.0..core_v0.15.0rc7). It is preferable to delete them to prevent users from being puzzled.