Skip to content

Conversation

@Hambaka
Copy link

@Hambaka Hambaka commented Sep 24, 2021

This PR is not ready for merge due to several issues:

  • Font issues.
  • Translation issues.

There are two font issues existed, waiting for solution.

  • Font size: The default font size is too small, will result poor readability of Chinese hanzi. But changing font size may also cause other problems.
  • The hanzi/kanji shape conflict among CJK: Many hanzi/kanji share same unicode, but the shape is different in different languages. To show this difference, it really depend on font itself.

Translation issues:

  • Waiting for other Chinese native speaker to look over the translation. Though I think headers pictures are ok.
  • Still need to change some translations after Metroid Dread released, need to refer to part of the new official Chinese translation in M:D. (Revision Completed)

@Miepee Miepee marked this pull request as draft January 19, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant