feat(comms): move comms + listeners to daemon ownership (#482)#484
Merged
ALRubinger merged 2 commits intomainfrom May 6, 2026
Merged
feat(comms): move comms + listeners to daemon ownership (#482)#484ALRubinger merged 2 commits intomainfrom
ALRubinger merged 2 commits intomainfrom
Conversation
Final ADR-0012 cleanup: per-launch CommsServer (~530 lines of unix socket IPC) is replaced by four HTTP long-poll endpoints on the daemon, and Slack/Discord listener startup moves to a vault-unlock callback that fires from POST /v1/vault/unlock. - Drop notifications: from per-project policy schema; types live in internal/config (via #481). - Move NotifyQueue + listener startup helpers from internal/launch to internal/comms; daemon owns the queue and the registry of active listeners across the lifetime of the process. - Add four OpenAPI endpoints under /v1/sessions/{id}/comms/ — messages (GET), send / draft / http (POST). Send-shaped endpoints register on the daemon's existing ActionApprovalQueue and long-poll for the user verdict, mirroring the 9A shell-approval pattern from #479. - Wire app.Config.OnVaultUnlock; UnlockLocalVault fires it synchronously after swapping the unlocked inner vault into the LockableVault wrapper. The daemon registers a callback that resolves Slack/Discord tokens and starts listeners. - Switch aileron-mcp's four comms tools from the unix socket dial to HTTP. AILERON_COMMS_SOCKET is gone; AILERON_COMMS_URL + AILERON_SESSION_ID replace it. - Strip launch-side comms: delete commsserver.go, the bridge / startup helpers in launcher.go, and the per-session unix socket binding. Launch's only remaining comms job is to set AILERON_COMMS_URL=daemonURL on the agent's environment. - Update Slack/Discord guides to point at ~/.aileron/config.yaml. - showStatusNotifications now reads from the user-scoped config. Closes the comms half of #454. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
🚅 Deployed to the aileron-pr-484 environment in aileron
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #484 +/- ##
==========================================
- Coverage 82.36% 82.18% -0.18%
==========================================
Files 236 237 +1
Lines 24127 24134 +7
==========================================
- Hits 19872 19835 -37
- Misses 3117 3137 +20
- Partials 1138 1162 +24
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Push patch coverage above the 80% bar: - Extract `startBuiltListeners` from `StartListeners` so tests can drive the connect/listen/bridge phase with fake listeners. Covers happy path, Connect-error skip, Listen-error skip, mixed good/bad list. StartListeners: 34.8% → 80%; startBuiltListeners: 100%. - Add 503/400/ctx-cancel branch tests for `DraftCommsReply` (73.7% → 89.5%) and matching shape tests for `SendCommsMessage` (80.5% → 90.2%) and `RequestCommsHTTP` (83.9% → 87.1%). internal/comms: 87.0% → 89.5%. internal/app: 79.9% → 80.2%. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final ADR-0012 cleanup. Replaces the per-launch
CommsServer(~530 lines of unix-socket IPC) with four HTTP long-poll endpoints on the daemon, and moves Slack/Discord listener startup to a vault-unlock callback. Closes the comms half of #454.notifications:from the per-project policy schema; the types now live ininternal/config(added in feat(config): add user-level AileronConfig with notifications schema #481).NotifyQueue+ listener startup helpers frominternal/launchtointernal/comms. The daemon owns one queue + one listener registry, shared across all launches.Test plan
🤖 Generated with Claude Code