chore(deps-dev): bump secretlint from 12.3.1 to 13.0.2#61
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
📝 WalkthroughWalkthroughThe pull request updates the ChangesDependency Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Bumps [secretlint](https://github.com/secretlint/secretlint) from 12.3.1 to 13.0.2. - [Release notes](https://github.com/secretlint/secretlint/releases) - [Commits](secretlint/secretlint@v12.3.1...v13.0.2) --- updated-dependencies: - dependency-name: secretlint dependency-version: 13.0.2 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/secretlint-13.0.2
branch
from
ce43f02 to
20adb24
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 75: Update the `@secretlint/secretlint-rule-preset-recommend` dependency to
match secretlint v13 by changing the version specifier for
"`@secretlint/secretlint-rule-preset-recommend`" from "^12.2.0" to "^13.0.2" in
package.json so the preset and core are on the same major version and avoid
compatibility/runtime issues.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: e0039e13-e054-4941-9600-93ed4d3d1cc8
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
| "lint-staged": "^16.4.0", | ||
| "prettier": "^3.8.3", | ||
| "secretlint": "^12.2.0", | ||
| "secretlint": "^13.0.2", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify secretlint/preset compatibility from npm metadata (read-only)
set -euo pipefail
npm view secretlint@13.0.2 version peerDependencies dependencies --json
npm view `@secretlint/secretlint-rule-preset-recommend`@12.2.0 version peerDependencies dependencies --json
npm view `@secretlint/secretlint-rule-preset-recommend`@13.0.2 version peerDependencies dependencies --jsonRepository: AIX-Format/PiWorker-OS
Length of output: 413
🏁 Script executed:
cat -n package.json | sed -n '65,80p'Repository: AIX-Format/PiWorker-OS
Length of output: 589
Upgrade @secretlint/secretlint-rule-preset-recommend to match secretlint v13.
Line 75 upgrades secretlint to ^13.0.2, but Line 70 keeps @secretlint/secretlint-rule-preset-recommend at ^12.2.0. The major version gap between the core (v13) and preset (v12) will cause compatibility issues. Secretlint v13's internal dependencies are all pinned to v13.0.2, confirming structural changes that require the matching preset version. Upgrade the preset to ^13.0.2 to ensure consistent rule loading and avoid runtime failures.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@package.json` at line 75, Update the
`@secretlint/secretlint-rule-preset-recommend` dependency to match secretlint v13
by changing the version specifier for
"`@secretlint/secretlint-rule-preset-recommend`" from "^12.2.0" to "^13.0.2" in
package.json so the preset and core are on the same major version and avoid
compatibility/runtime issues.
1 participant
Bumps secretlint from 12.3.1 to 13.0.2.
Release notes
Sourced from secretlint's releases.
... (truncated)
Commits
56012e5v13.0.2 (#1566)63a6fd4v13.0.1 (#1565)f0ec5c0Fix secp256k1 private key detection to avoid false positives (#1564)5c2df17Update github/codeql-action action to v3.35.4 (#1563)3cbe8d9Update dependency@types/nodeto ^25.7.0 (#1562)b5bd0a9Update dependency vitest to ^4.1.6 (#1561)4356d15Update textlint to ^15.6.1 (#1559)4d13ae9Update rhysd/github-action-benchmark action to v1.22.1 (#1558)8a1b8abchore(CI): update to pkgdeps/automerge-gate@4.1 (#1557)5351a4dUpdate dependency turbo to ^2.9.12 (#1556)Summary by CodeRabbit
**Disclaimer This is AxiomID Review Agent.
Greptile Summary
This dependabot PR bumps
secretlintfrom12.3.1to13.0.2inpackage.jsonand updates the corresponding lock file entries, but leaves@secretlint/secretlint-rule-preset-recommendat^12.2.0. The two packages are part of the same monorepo and must stay in lockstep.secretlintCLI is updated to^13.0.2, but the companion rule preset@secretlint/secretlint-rule-preset-recommendremains at^12.2.0(locked to12.3.1), creating a major-version mismatch that will cause secretlint to fail at runtime.@secretlint/*sub-packages in the lock file (@secretlint/core,@secretlint/types,@secretlint/config-loader, etc.) are correctly updated to13.0.2; only the rule preset is out of sync.^13.0.2before merging.Confidence Score: 4/5
The bump is incomplete: the rule preset is left at v12 while the secretlint core moves to v13, which will break the pre-commit hook on every developer machine until fixed.
The @secretlint/secretlint-rule-preset-recommend package is still locked to 12.3.1 in the lock file. secretlint v13 changed internal types across the monorepo; loading a v12 preset against a v13 core causes a runtime failure in the secretlint pre-commit hook, blocking all commits. The fix is a one-line bump to ^13.0.2 followed by a fresh npm install.
package.json — the rule preset version needs to be updated alongside the secretlint CLI bump
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[git commit] --> B[husky pre-commit hook] B --> C[npx secretlint] C --> D{Load config} D --> E[config-loader v13] E --> F[Load rule preset] F --> G[rule-preset-recommend v12] G -->|Type mismatch with types v13| H[Runtime failure] H --> I[Commit blocked for all developers] style G fill:#f88,stroke:#c00 style H fill:#f88,stroke:#c00 style I fill:#f88,stroke:#c00Comments Outside Diff (1)
package.json, line 70 (link)@secretlint/secretlint-rule-preset-recommendis still pinned to^12.2.0(resolves to12.3.1in the lock file) whilesecretlintcore was just bumped to13.0.2. All@secretlint/*internal packages (@secretlint/core,@secretlint/types,@secretlint/walker, etc.) are now at13.0.2in the lock file. A v12 rule preset loaded against a v13 core will encounter incompatible internal types, causingsecretlintto fail at runtime — this breaks the pre-commit hook in.husky/pre-commitand blocks every commit for developers.Reviews (2): Last reviewed commit: "chore(deps-dev): bump secretlint from 12..." | Re-trigger Greptile