Skip to content

chore(deps-dev): bump lint-staged from 16.4.0 to 17.0.5 #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Moeabdelaziz007 merged 1 commit into from
May 18, 2026
Merged

chore(deps-dev): bump lint-staged from 16.4.0 to 17.0.5 #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
136 changes: 69 additions & 67 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"@secretlint/secretlint-rule-preset-recommend": "^12.2.0",
"@types/node": "^25",
"husky": "^9.1.7",
"lint-staged": "^16.4.0",
"lint-staged": "^17.0.5",
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify Node/Git compatibility signals in repo config (read-only).

set -euo pipefail

echo "== package.json engines =="
cat package.json | jq -r '.engines'

echo
echo "== lint-staged version =="
cat package.json | jq -r '.devDependencies["lint-staged"]'

echo
echo "== CI/setup-node versions (if present) =="
fd -i '.*(workflow|workflows).*\.ya?ml$' .github 2>/dev/null | while read -r f; do
  echo "-- $f"
  rg -n 'setup-node|node-version|node-version-file' "$f" || true
done

echo
echo "== Git version constraints mentioned in repo files (if any) =="
rg -n 'git.*2\.32|minimum git|requires git|git version' README.md .github package.json 2>/dev/null || true

Repository: AIX-Format/PiWorker-OS

Length of output: 258

🏁 Script executed:

# Check if .github directory exists and list its contents
ls -la .github 2>/dev/null || echo ".github directory not found"

Repository: AIX-Format/PiWorker-OS

Length of output: 641

🌐 Web query:

lint-staged v17 minimum Node.js version requirements

💡 Result:

As of May 2026, lint-staged version 17 requires a minimum Node.js version of 22.22.1 [1][2][3]. With the release of v17.0.0, support for Node.js v20 was dropped [1][2]. Users are advised to upgrade their Node.js environment to at least v22.22.1, which is an active Long Term Support (LTS) version, to ensure compatibility with lint-staged v17 [1][3]. Additionally, lint-staged v17 requires a Git version of at least 2.32.0 [1][2].

Citations:

🏁 Script executed:

# List workflow files
ls -la .github/workflows/

echo
echo "=== Checking for Node version pinning in workflows ==="
rg -n 'node-version|setup-node' .github/workflows/ --type yaml || echo "No Node version constraints found in workflows"

Repository: AIX-Format/PiWorker-OS

Length of output: 871

Align Node engine floor with lint-staged@17 minimum requirement in both package.json and CI workflows.

Bumping to lint-staged@^17.0.5 while keeping "node": ">=22.x" in both package.json and CI workflows allows unsupported Node 22 patch versions (below 22.22.1) to run. Tighten the constraint to >=22.22.1 in both places to ensure compatibility.

Required changes

Update package.json:

-  "engines": {
-    "node": ">=22.x"
-  },
+  "engines": {
+    "node": ">=22.22.1"
+  },

Update .github/workflows/ci.yml (lines 26 and 132):

-          node-version: "22.x"
+          node-version: "22.22.1"

Update .github/workflows/gemini-test.yml (line 24):

-          node-version: '22.x'
+          node-version: "22.22.1"
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` at line 73, The Node engine constraint is too permissive for
lint-staged@17; update the package.json "engines" entry for "node" to
">=22.22.1" (matching lint-staged@17 minimum) and ensure any CI workflow
node-version settings are tightened similarly: change the node-version entries
in the CI workflow(s) (the two occurrences referenced around the workflow job
setup and matrix) and in the Gemini test workflow node-version to use "22.22.1"
or ">=22.22.1" so CI and local install enforce the same minimum Node version as
the upgraded "lint-staged" dependency.

"prettier": "^3.8.3",
"secretlint": "^13.0.2",
"dotenv": "^17.4.2"
Expand Down
Loading