fragment_response: optional selector + vendor datastar.js bundle#23
Open
joaomdsg wants to merge 2 commits into
Open
fragment_response: optional selector + vendor datastar.js bundle#23joaomdsg wants to merge 2 commits into
joaomdsg wants to merge 2 commits into
Conversation
Datastar v1.0 morphs into whichever element matches the outermost id in the response payload, so most fragment handlers no longer need a datastar-selector header. Make the selector argument optional + also accept the keyword form; only emit the header when the caller explicitly overrides the id-based default. Positional form preserved. Matches the Unreleased CHANGELOG entry shipped earlier.
So the bundled counter and CairoMakie demos run offline without the first-launch Downloads.download() step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fragment_response:selectorbecomes optional with a kw-form (fragment_response(body; selector=…)). Datastar v1.0 morphs into whichever element matches the outermost id in the payload, so most handlers no longer need to pass a selector; thedatastar-selectorheader is emitted only when the caller explicitly overrides the id-based target. Positional form preserved. Matches the Unreleased CHANGELOG entry already onmain.examples/datastar-v1.0.1.js: vendors the Datastar v1.0.1 bundle so the bundled counter and CairoMakie demos run offline without the first-launchDownloads.download().Test plan
julia --project=. -e 'using Pkg; Pkg.test()'— 515/515 pass locallyfragment_responsekw-form passes