setup.sh merges user hooks instead of overwriting (DPLAN-0234 Strand C). AIPass bridge entries are refreshed on every install (bridges/claude.py marker); user-wired hooks and custom events now survive install/re-run. Fixture-verified: customs preserved, stale bridge entries replaced without duplicates, fresh-install output shape-identical (7 events, 6+6 entries). Background: full hook fire-test on fresh Linux Docker install passed 17/17.#658
Conversation
…C fix) - AIPass bridge entries (bridges/claude.py marker) refreshed on every install; user-wired hooks and custom events preserved - Fixture-verified: customs survive, stale bridge entries replaced no-dupe, fresh-install output shape-identical - Context: full 17/17 hook fire-test passed on fresh Linux Docker install
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…n.exe (DPLAN-0234 Strand C) - bash passes IS_WINDOWS into the hook-install heredoc; bridge string picks .venv/Scripts/python.exe vs .venv/bin/python3 - @hooks assessment: $AIPASS_HOME expansion fine (CC runs hooks via Git Bash on Windows), bridge has zero POSIX assumptions — interpreter path was the only gap - Verified both OS modes + merge-marker/custom-hook regression
- README: setup.sh mention tied to the ./aipass install command + notes hook merge-not-overwrite - CONTRIBUTING: contributor bootstrap is ./aipass install --no-init (no first-project scaffold in the engine repo)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.