Skip to content

Geant4InputHandling: Add DecayByGeant configuration option#1548

Merged
andresailer merged 3 commits intoAIDASoft:masterfrom
andresailer:ddsimLetDecay
Jan 27, 2026
Merged

Geant4InputHandling: Add DecayByGeant configuration option#1548
andresailer merged 3 commits intoAIDASoft:masterfrom
andresailer:ddsimLetDecay

Conversation

@andresailer
Copy link
Copy Markdown
Member

@andresailer andresailer commented Jan 5, 2026

BEGINRELEASENOTES

ENDRELEASENOTES

Todo:

  • Add a test to check that this
    • Does not break in the future
    • Does not break existing use-cases

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 5, 2026

Test Results

   18 files     18 suites   6h 49m 2s ⏱️
  374 tests   374 ✅ 0 💤 0 ❌
3 296 runs  3 296 ✅ 0 💤 0 ❌

Results for commit 93a0eb8.

♻️ This comment has been updated with latest results.

@andresailer andresailer changed the title Geant4InputHandling: Only set the propertime of a particle if it is l… Geant4InputHandling: Add DecayByGeant configuration option Jan 27, 2026
…arger than 0, otherwise keep Geant4 default.

Note that this might break if Geant4particles are copied, because decays are only copied when properTime is >= 0
Comment thread DDG4/python/DDSim/Helper/Physics.py Outdated
@andresailer andresailer force-pushed the ddsimLetDecay branch 2 times, most recently from 15caa36 to 8b65fed Compare January 27, 2026 11:08
@andresailer andresailer marked this pull request as ready for review January 27, 2026 11:09
@andresailer andresailer force-pushed the ddsimLetDecay branch 5 times, most recently from b2918ce to 082ba40 Compare January 27, 2026 12:56
Comment thread DDG4/include/DDG4/Geant4PrimaryHandler.h Outdated
@andresailer andresailer merged commit 516e692 into AIDASoft:master Jan 27, 2026
15 checks passed
@andresailer
Copy link
Copy Markdown
Member Author

Tested locally, works as intended.

@andresailer andresailer deleted the ddsimLetDecay branch January 27, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(yet another) question about simulating particle lifetime in ddsim...

2 participants