Apply repository-wide Ruff formatting and minimal lint cleanup for PR #49#50
Draft
gaoziqian123 with Copilot wants to merge 1 commit into
Draft
Apply repository-wide Ruff formatting and minimal lint cleanup for PR #49#50gaoziqian123 with Copilot wants to merge 1 commit into
gaoziqian123 with Copilot wants to merge 1 commit into
Conversation
Copilot
AI
changed the title
[WIP] Fix CI failure due to formatting check
Apply repository-wide Ruff formatting and minimal lint cleanup for PR #49
May 26, 2026
booth-algo
added a commit
that referenced
this pull request
May 29, 2026
- PLENA_Compiler -> fix/clm60m-mlen256-mask-nan (#50): finite score-mask (fp_preload[2] -inf -> -6e4) eliminates the MLEN>=256 NaN; comparison_params spans column blocks at the physical-row stride. - PLENA_Tools -> fix/native-mlen256-comparison (#4): reorder_stride_mode col_block_stride + logical-width slice + compact golden-parser support. - emulator_runner: thread physical_rows from comparison_params into compare_vram_with_golden (needed by the col-block reorder). - smolvlm2_256m.yaml: add native_32x32x4_b1 preset for sub-64 experiments. Native CLM-60M 1-layer decoder now PASSES at MLEN=256 (allclose 100%, MSE 8.5e-6) and MLEN=64 (100%, non-regression).
7 tasks
booth-algo
added a commit
that referenced
this pull request
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #49 is blocked by the CI lint workflow because
ruff format --checkreports 25 non-compliant files, including the tooling files called out in the failing job logs. This update brings the branch in line with the repository’s Ruff formatting/lint expectations with mechanical changes only.Scope: formatting alignment with CI
transactional_emulator/tools/test_data_gen.pytransactional_emulator/tools/trace_gp.pytransactional_emulator/tools/view_mem.pytransactional_emulator/testbench/Minimal lint-only follow-ups required by Ruff
Representative mechanical adjustment
Original prompt
Fix the failing CI for pull request #49 in repository
AICrossSim/PLENA_Simulator.Context:
77863879002from workflowCI.uv run ruff format --check .Would reformat: transactional_emulator/tools/test_data_gen.pyWould reformat: transactional_emulator/tools/trace_gp.pyWould reformat: transactional_emulator/tools/view_mem.py25 files would be reformatted, 8 files already formattedProcess completed with exit code 1.github/workflows/ci.ymland confirms the failing lint job runs:uv python install 3.12uv sync --no-install-projectuv run ruff format --check .uv run ruff check .Goal:
Files directly mentioned by the log and worth checking first:
transactional_emulator/tools/test_data_gen.pytransactional_emulator/tools/trace_gp.pytransactional_emulator/tools/view_mem.pyImportant guidance:
uv run ruff format --check .uv run ruff check .The following is the prior conversation context from the user's chat exploration (may be truncated):
User: Please find a solution for failing job 77863879002. Use the logs, job definition, and any referenced files where the failure occurred. Keep your response focused on the solution and include code suggestions when appropriate.
Assistant: The failing job is the format check, not a test or runtime failure.
Root cause
In the CI workflow, the failing step is:
Run ruff format checkin.github/workflows/ci.ymlThe logs show:
Would reformat: transactional_emulator/tools/test_data_gen.pyWould reformat: transactional_emulator/tools/trace_gp.pyWould reformat: transactional_emulator/tools/view_mem.py25 files would be reformattedProcess completed with exit code 1So the solution is to apply the project formatter and commit the result.
Files directly referenced by the failure
transactional_emulator/tools/test_data_gen.pytransactional_emulator/tools/trace_gp.pytransactional_emulator/tools/view_mem.pyRecommended fix
Run this locally at the repo root:
Then commit the formatting changes.
Code suggestions
These files mostly fail on style/layout, not logic. Typical fixes Ruff will apply here include:
transactional_emulator/tools/test_data_gen.pyLikely reorder imports and normalize spacing around function definitions/default args.
Suggested formatted shape:
transactional_emulator/tools/trace_gp.pyThis f...
This pull request was created from Copilot chat.