bug: add tool create command #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximilien
reviewed
Sep 26, 2025
Contributor
maximilien
left a comment
maximilien
left a comment
There was a problem hiding this comment.
Let's make sure to add README or user guide examples
LGTM
Contributor
|
You also have conflict from previous PR merger @akihikokuroda |
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
akihikokuroda
force-pushed
the
createtools
branch
from
689b2d8 to
be5f7d5
Compare
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
maximilien
approved these changes
Oct 8, 2025
Contributor
maximilien
left a comment
maximilien
left a comment
There was a problem hiding this comment.
Just add some tests... otherwise LGTM
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Collaborator
Author
|
The tests are added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8
add tool create command