Merged
Conversation
haz
requested changes
Jun 4, 2025
Contributor
haz
left a comment
haz
left a comment
There was a problem hiding this comment.
Only one minor thing to discuss.
| } | ||
| ], | ||
| "call":"{package_name} {domain} {problem} --search '{search_algorithm}'", | ||
| "call":"{package_name} -k 10 -q 1.0 -H lmcut {domain} {problem} >> plan", |
Contributor
There was a problem hiding this comment.
This is the only thing that gives me pause. You've moved away all the configuration and hard-coded the cli options. Why not leave it exposed? Would kstar use these as defaults? If not, you could beef up the run shell script to look and set defaults.
The reason it's nice to expose these in the json as args is that it will pre-populate the UI for those settings (online editor, and I think vscode as well). So running kstar from there (hosted on solver.planning.domains), could be configured for the individual user.
haz
reviewed
Jun 5, 2025
haz
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved old kstar to kstar-legacy
Added modern kstar version installation via pip