Skip to content

Conversation

@j-skiba
Copy link

@j-skiba j-skiba commented Jan 15, 2026

Description

Purpose of the admissioncheck controller is to let know Kueue that slice controller is functional. In the meantime Kueue adds a finalizer which may result in a conflict error and excessive logs.

admissioncheck managedFields:

 managedFields:
  - apiVersion: kueue.x-k8s.io/v1beta1
    fieldsType: FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .: {}
          f:kubectl.kubernetes.io/last-applied-configuration: {}
      f:spec:
        .: {}
        f:controllerName: {}
        f:retryDelayMinutes: {}
    manager: kubectl-client-side-apply
    operation: Update
    time: "2026-01-15T07:30:58Z"
  - apiVersion: kueue.x-k8s.io/v1beta1
    fieldsType: FieldsV1
    fieldsV1:
      f:metadata:
        f:finalizers:
          .: {}
          v:"kueue.x-k8s.io/resource-in-use": {}
    manager: kueue
    operation: Update
    time: "2026-01-15T07:30:58Z"
  - apiVersion: kueue.x-k8s.io/v1beta1
    fieldsType: FieldsV1
    fieldsV1:
      f:status:
        .: {}
        f:conditions:
          .: {}
          k:{"type":"Active"}:
            .: {}
            f:lastTransitionTime: {}
            f:message: {}
            f:observedGeneration: {}
            f:reason: {}
            f:status: {}
            f:type: {}
    manager: manager
    operation: Update
    subresource: status
    time: "2026-01-15T07:30:58Z"
  name: slice-ac
  resourceVersion: "1131"
  uid: 58d426c4-4209-4b91-b525-9dc0b14141e7

Issue


Testing

manual testing

@j-skiba j-skiba marked this pull request as ready for review January 15, 2026 08:44
@j-skiba j-skiba changed the title Use patch in admissioncheck controller [slice] Use patch in admissioncheck controller Jan 15, 2026
@PBundyra
Copy link
Collaborator

Can we use SSA as in #966

@j-skiba j-skiba requested a review from pajakd as a code owner January 16, 2026 14:57
@j-skiba j-skiba force-pushed the use-patch-in-admissioncheck-ctrl branch from 49f83fa to 03e2a89 Compare January 16, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants