Skip to content

fix(ci): Remove hardcoded cloud_runner from maxtext_jupyter_notebooks #4355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mesakhcienet wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −4
Draft

fix(ci): Remove hardcoded cloud_runner from maxtext_jupyter_notebooks #4355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
769e0a3
fix: Revert notebook CI to use v6e-4 runners
mesakhcienet Jul 6, 2026
4a6aff2
Update run_jupyter_notebooks.yml
mesakhcienet Jul 6, 2026
66f4925
Update run_jupyter_notebooks.yml
mesakhcienet Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci_pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,9 @@ jobs:
fail-fast: false
with:
device_type: tpu
device_name: v6e-8
device_name: v6e-4
base_image: maxtext-unit-test-tpu:py312
cloud_runner: linux-x86-ct6e-180-8tpu
cloud_runner: linux-x86-ct6e-180-4tpu
maxtext_sha: ${{ needs.build_and_upload_maxtext_package.outputs.maxtext_sha }}
secrets:
HF_TOKEN: ${{ secrets.HF_TOKEN }}
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/run_jupyter_notebooks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,11 +107,15 @@ jobs:
$PYTHON_EXE -m ipykernel install --user --name maxtext_venv
# Run Hugging Face authentication
hf auth login --token "$HF_TOKEN"
if [ -n "$HF_TOKEN" ]; then
hf auth login --token "$HF_TOKEN"
else
echo "Warning: HF_TOKEN is empty (likely because this is a PR from a fork). Skipping Hugging Face authentication."
fi
for notebook in "$MAXTEXT_NOTEBOOKS_ROOT"/*.ipynb; do
filename=$(basename "$notebook")
if [[ "$filename" == "sft_llama3_demo_gpu.ipynb" || "$filename" == "maxtext_with_gepa.ipynb" || "$filename" == "demo_decoding.ipynb" ]]; then
if [[ "$filename" == "sft_llama3_demo_gpu.ipynb" || "$filename" == "maxtext_with_gepa.ipynb" || "$filename" == "rl_llama3_demo.ipynb" || "$filename" == "demo_decoding.ipynb" ]]; then
echo "Skipping $filename"
continue
fi
Expand All @@ -127,6 +131,7 @@ jobs:
echo "Post-notebook disk cleanup for $filename ..."
rm -rf "$MAXTEXT_PKG_DIR"/*_output
rm -rf "$HOME/.cache/huggingface/hub"
done
- name: Upload Outputs
if: always()
Expand Down
Loading