fix: repaired bug in thin_disk model that caused it to miss the disk #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipole 1.5
Port forward GNW's old zone-by-zone emission histogramming code. Just drops any (signed) change in intensity from unpolarized transport (dI) into a bin corresponding to the nearest zone (via Xtoijk). Implementation adds a static global array of grid size, accessible to any file importing grid.h. Not modular but not invasive...
…tended to support similar-but-hdf5-based meshblock files.
refs added
Added BSD 3-Clause License
don't zero out carried intensity or depths in integrate_emission(...) thanks @zgelles
add assertive warning to histogram code.
Merge remote-tracking branch 'origin/master' into feature/kharma
…ly. Also, function to parse par file saved to dumps
KHARMA reader
… with certain hdf5 installations Handle old format better
fix compile for default configuration on ias/callisto machine
Write a `fluid_header` to image files.
...to make clear why B_unit is being used
... to clarify use of units
commented model.c
batch reads for meshblock model for improved speed at binary load time
Xtoijk function rewrite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thindisk_region would only look for equator-crossings in the first half of a geodesic step, now given X initial and Xhalf it extrapolates linearly to Xfinal and assesses whether the equator will be crossed. Also added a supermassive black hole example par file, allowed readin of Rout from par file, added default value for Rout, and minor edits for clarity.