Fix: Use relative URL for JSON-RPC endpoint instead of absolute URL#16
Open
Fix: Use relative URL for JSON-RPC endpoint instead of absolute URL#16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current way of defining the JSON-RPC endpoint was not working in the case Lyrion is behind an url with https. Most of the plugin was working only changing the virtual library didn't had an impact.
Digging in the plugin code (with the help of a LLM), I found out that defining a relative URL (instead of the absolute one) works. Hence this PR.
I tested on my LMS and it works correctly, didn't see any side effect, but I can test more if needed.