This repository was archived by the owner on Oct 25, 2023. It is now read-only.
adjusted regex for matching external stack errors when SLS_DEBUG is set#180
Open
MHekert wants to merge 1 commit intoACloudGuru:masterfrom
Open
adjusted regex for matching external stack errors when SLS_DEBUG is set#180MHekert wants to merge 1 commit intoACloudGuru:masterfrom
MHekert wants to merge 1 commit intoACloudGuru:masterfrom
Conversation
8f8e0a4 to
0e5c4c4
Compare
2145678 to
512a6be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did you implement:
When running
sls deploywithSLS_DEBUG=*errors messages have additional text and are not correctly detected by current regex. e.gwhen run
sls deploywithoutSLS_DEBUG=*error message is following:and when
SLS_DEBUG=*is set it has following format:How did you implement it:
I removed requirement for matching a beginning or ending of string and added some extra text to prevent false positive matching.
How can we verify it:
Set
externalStackto trueRun
sls deploywith and withoutSLS_DEBUG=*set for stage present in the list and for stage not present in the list.