Accountable HTLCs #3217
Merged
Accountable HTLCs #3217
+827
−914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomash-acinq
force-pushed
the
accountability
branch
4 times, most recently
from
c44e38f to
7e21640
Compare
thomash-acinq
force-pushed
the
accountability
branch
6 times, most recently
from
f8160e5 to
d807c65
Compare
Add accountability signal for HTLCs, it replaces endorsement. See lightning/bolts#1280
thomash-acinq
force-pushed
the
accountability
branch
from
d807c65 to
1a162d1
Compare
We update codecs to use `case class` instead of `case object`, like we do for the similar `require_confirmed_inputs` TLV, which lets us use the helper functions on TLV streams and provide better consistency. We add documentation to the acountability TLV fields. We also simplify the trait hierarchy in `PaymentOnion.scala` by removing unnecessary additions.
We refactor the following parts of the payment flow: - when fetching confidence score, the downstream node is always known, we don't need to use an `Option` in `GetConfidence` - we remove the restrictions that require accountability for on-the-fly funding, we don't want to negatively impact wallets yet - we never fail HTLCs based on accountability / incoming confidence, we only log that we would have failed them to collect data, it's way too early to actually enforce any of those restrictions - we reorder the `accountability` parameter in various functions, to make it appear before optional, less important parameters (for example custom TLVs) - we revert a bunch of small, unnecessary changes to minimize the diff with `master` We also add documentation and comments to help readers.
t-bast
reviewed
Dec 22, 2025
Member
t-bast
left a comment
t-bast
left a comment
There was a problem hiding this comment.
This is simpler and less invasive than the previous endorsement mechanism, I like it. Let's get that on master soon to avoid dealing with merge conflicts since a lot of tests are being updated (hopefully for the last time).
I think it's fine to set the accountability bit in the route blinding data even though it isn't in the spec yet, we can still change it on master in a follow-up PR if the final decision is slightly different than what we're doing.
eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/ChannelRelay.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/NodeRelay.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/reputation/ReputationRecorder.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/HtlcTlv.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/PaymentOnion.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/reputation/ReputationSpec.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/ChannelRelay.scala
Outdated
Show resolved
Hide resolved
Member
|
Another reason to get this change included is that we have exceptions in our logs for an array out of bounds access that crashes the reputation recorder. I haven't figured out where it comes from because the code is quite hairy, but it gets simpler after this change so hopefully it's fixed or easier to investigate! |
Member
Author
|
I've merged your changes. And added another commit to make sure that we don't set the accountable bit if the HTLC does not support it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add accountability signal for HTLCs, it replaces endorsement.
See lightning/bolts#1280