Skip to content

Conversation

@penguian
Copy link
Collaborator

Tested with u-dq819/trunk@339310. See run output at gadi:/scratch/tm70/pcl851/cylc-run/u-dq819.trunk/run66.
See ACCESS-NRI/access-esm1.6-configs@test-historical...gen-cmip7-historical-aec62acb for a comparison of the namelist files.

@penguian penguian self-assigned this Nov 28, 2025
@penguian penguian linked an issue Nov 28, 2025 that may be closed by this pull request
@penguian penguian marked this pull request as draft November 28, 2025 12:21
@penguian
Copy link
Collaborator Author

Refactored, as I was not satisfied with the array order and formatting in the greenhouse gas namelists. Also, the code was needlessly complicated.

Re-tested with u-dq819/trunk@339310. See run output at gadi:/scratch/tm70/pcl851/cylc-run/u-dq819.trunk/run69.
See ACCESS-NRI/access-esm1.6-configs@test-historical...gen-cmip7-historical-48ad9373 for a comparison of the atmosphere/namelists files.

@penguian penguian marked this pull request as ready for review November 30, 2025 12:58
@penguian penguian requested review from MartinDix and atteggiani and removed request for MartinDix December 1, 2025 01:26
Copy link
Collaborator

@atteggiani atteggiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Paul.

I left a few suggestions.

@penguian penguian marked this pull request as draft December 7, 2025 23:04
* Extend the historical volcanic forcing to 2300

* Use cell.point for ym_constraint

* Reverse the order of the latitude bands
@penguian
Copy link
Collaborator Author

penguian commented Dec 8, 2025

Re-tested with u-dq819/trunk@339310. See run output at gadi:/scratch/tm70/pcl851/cylc-run/u-dq819.trunk/run72.
See ACCESS-NRI/access-esm1.6-configs@test-historical...gen-cmip7-historical-4b741dab for a comparison of the namelists file with the current version, and see https://github.com/ACCESS-NRI/access-esm1.6-configs/compare/gen-cmip7-historical-5670ea96..gen-cmip7-historical-4b741dab for a comparison between run68 and run72.

@penguian
Copy link
Collaborator Author

penguian commented Dec 8, 2025

@penguian penguian marked this pull request as draft December 8, 2025 05:05
@penguian penguian marked this pull request as ready for review December 8, 2025 05:50
@penguian penguian requested a review from blimlim December 8, 2025 05:50
Copy link
Collaborator

@blimlim blimlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @penguian, the changes look good to me. The model runs with the new namelist, and in the first month prints out

GHG concentrations (mmr) for model year  1850
CO2     0.43189E-03
CH4     0.44228E-06
N2O     0.41256E-06
CFC11   0.00000E+00
CFC12   0.00000E+00
CFC113  0.00000E+00
HCFC22  0.00000E+00
HFC125  0.00000E+00
HFC134a 0.00000E+00

so it looks like the new namelist is working

Copy link
Collaborator

@atteggiani atteggiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @penguian!
Looks good.

@penguian penguian merged commit 14d9085 into main Dec 16, 2025
1 check passed
@penguian penguian deleted the 108-ghg-update-to-test-historical-config branch December 24, 2025 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New test-historical config triggers a bug in GHG processing

4 participants