-
Notifications
You must be signed in to change notification settings - Fork 1
Add notes for first session #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@atteggiani any thoughts on why the pr-preview is failing? My guess is that the .githubactions pages are out of date. Can you point me towards your preferred more recent one? |
|
The workflow should be copied and modified from the Hive Docs one. Also, I'm noticing that this PR head is a fork. PR previews from forks are not working at the moment. |
Okay so before I do the workflow update I should disconnect this being a fork? |
No, a PR should be created from a branch of this repo for the PR preview to work correctly. Disconnecting the fork would simply make the forked repo (in this case |
Oh sorry, yes, I forgot Paige had done this work on her own fork. |
chrisb13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @paigem, looks great -- very detailed 😄
One small suggestion.
Note there's a few merge conflicts from today's session. I can fix those if you prefer.
| - Why use the GitHub search bar? | ||
| - See how a specific piece of code is written - how is it implemented in MOM6? Need to search through the code | ||
| - Dougie’s screen: Looking at [MOM6 fork on ACCESS-NRI GitHub org](https://github.com/ACCESS-NRI/MOM6) | ||
| - Can click on search at top or click “/“ to start a search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Can click on search at top or click “/“ to start a search | |
| - Can click on search at top or click `/` to start a search |
Added my notes to complement Chris's notes for the first session