Skip to content

Conversation

@paigem
Copy link

@paigem paigem commented Dec 5, 2025

Added my notes to complement Chris's notes for the first session

@chrisb13
Copy link
Collaborator

chrisb13 commented Dec 8, 2025

@atteggiani any thoughts on why the pr-preview is failing?

My guess is that the .githubactions pages are out of date. Can you point me towards your preferred more recent one?

@atteggiani
Copy link
Collaborator

The workflow should be copied and modified from the Hive Docs one.
Note the site_url field in the mkdocs.yml should also be changed to this.

Also, I'm noticing that this PR head is a fork. PR previews from forks are not working at the moment.

@chrisb13
Copy link
Collaborator

chrisb13 commented Dec 9, 2025

Also, I'm noticing that this PR head is a fork. PR previews from forks are not working at the moment.

Okay so before I do the workflow update I should disconnect this being a fork?

@atteggiani
Copy link
Collaborator

Also, I'm noticing that this PR head is a fork. PR previews from forks are not working at the moment.

Okay so before I do the workflow update I should disconnect this being a fork?

No, a PR should be created from a branch of this repo for the PR preview to work correctly. Disconnecting the fork would simply make the forked repo (in this case paigem/decoding-om3) separate from this repo.

@chrisb13
Copy link
Collaborator

chrisb13 commented Dec 9, 2025

No, a PR should be created from a branch of this repo for the PR preview to work correctly.

Oh sorry, yes, I forgot Paige had done this work on her own fork.

Copy link
Collaborator

@chrisb13 chrisb13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paigem, looks great -- very detailed 😄

One small suggestion.

Note there's a few merge conflicts from today's session. I can fix those if you prefer.

- Why use the GitHub search bar?
- See how a specific piece of code is written - how is it implemented in MOM6? Need to search through the code
- Dougie’s screen: Looking at [MOM6 fork on ACCESS-NRI GitHub org](https://github.com/ACCESS-NRI/MOM6)
- Can click on search at top or click “/“ to start a search
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Can click on search at top or click “/“ to start a search
- Can click on search at top or click `/` to start a search

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants