-
Notifications
You must be signed in to change notification settings - Fork 24
Xarray + numpy reshape tests #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xarray + numpy reshape tests #227
Conversation
69fbe00 to
752cc02
Compare
Pull Request Test Coverage Report for Build 20304891244Details
💛 - Coveralls |
|
hi @gemmaellen I'm adding you as a reviewer as you worked on the xarray reshape code that some of these tests are for. Some input on the applying encoders could would be helpful. Seems like the code never gets run since dataset attributes are always overwritten! |
packages/pipeline/src/pyearthtools/pipeline/operations/xarray/reshape.py
Outdated
Show resolved
Hide resolved
|
Sorry for the delay here ... a few things at work meant a building of reviews, and I had some difficult refactoring to do on "scores". I'll get to this next week, maybe earlier. |
|
Thanks. Great to get the increase in test coverage. At some point it might be nice to go through the nocover areas and either remove the redundant code or figure out the requirement and developer intent to see if there is an additional case that needs testing, but getting coverage up with reasonable tests is what's important. |
This brings xarray and numpy reshape tests to 100%. There were a couple if statements that were always true, so I set them as no cover.