Skip to content

Conversation

@edoyango
Copy link
Collaborator

This brings xarray and numpy reshape tests to 100%. There were a couple if statements that were always true, so I set them as no cover.

@edoyango edoyango force-pushed the xarray_reshape_tests branch from 69fbe00 to 752cc02 Compare November 21, 2025 03:16
@edoyango edoyango requested a review from gemmaellen November 21, 2025 03:18
@coveralls
Copy link

coveralls commented Nov 21, 2025

Pull Request Test Coverage Report for Build 20304891244

Details

  • 54 of 56 (96.43%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 64.983%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/pipeline/tests/operations/numpy/test_numpy_reshape.py 43 45 95.56%
Totals Coverage Status
Change from base Build 20304024396: 0.2%
Covered Lines: 10480
Relevant Lines: 15767

💛 - Coveralls

@edoyango
Copy link
Collaborator Author

hi @gemmaellen I'm adding you as a reviewer as you worked on the xarray reshape code that some of these tests are for. Some input on the applying encoders could would be helpful. Seems like the code never gets run since dataset attributes are always overwritten!

@edoyango edoyango requested a review from tennlee November 21, 2025 03:22
@tennlee
Copy link
Collaborator

tennlee commented Dec 10, 2025

Sorry for the delay here ... a few things at work meant a building of reviews, and I had some difficult refactoring to do on "scores". I'll get to this next week, maybe earlier.

@tennlee
Copy link
Collaborator

tennlee commented Dec 17, 2025

Thanks. Great to get the increase in test coverage. At some point it might be nice to go through the nocover areas and either remove the redundant code or figure out the requirement and developer intent to see if there is an additional case that needs testing, but getting coverage up with reasonable tests is what's important.

@tennlee tennlee merged commit 3988f09 into ACCESS-Community-Hub:develop Dec 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants