Skip to content

Conversation

@ThermoDev
Copy link
Contributor

Add further tests for test_catalog:

  • Tests saving and loading functionality
  • Edge cases testing None strings/objects

Add default entries in Catalog class definition:

  • Entries were put down as optional, but entries.items() is called on the variable.
  • Setting the default to {} fixes the issue.
  • This is important in Catalog.load() that instantiates this class without any arguments.

@coveralls
Copy link

coveralls commented Nov 14, 2025

Pull Request Test Coverage Report for Build 19356592272

Details

  • 42 of 42 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 63.223%

Totals Coverage Status
Change from base Build 19354196491: 0.4%
Covered Lines: 10013
Relevant Lines: 15459

💛 - Coveralls

* Entries were put down as optional, but entries.items()
* is called on the variable.
* Setting to None as dict reference can be a pointer to
* new instantiations.
* This is important in Catalog.load() that instantiates
* this class without any arguments.
* Also checks entries before iterating through items()
@ThermoDev ThermoDev marked this pull request as ready for review November 14, 2025 05:50
@ThermoDev ThermoDev marked this pull request as draft November 14, 2025 06:18
@ThermoDev ThermoDev changed the title Add default entires in Catalog and more tests Add default entries in Catalog and more tests Nov 14, 2025
Michael Pegios added 2 commits November 14, 2025 17:40
* Tests saving and loading functionality
* Edge cases testing None strings/objects
@ThermoDev ThermoDev marked this pull request as ready for review November 14, 2025 07:14
@tennlee tennlee merged commit c40c502 into ACCESS-Community-Hub:develop Nov 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants