-
Notifications
You must be signed in to change notification settings - Fork 24
feat: Add entrypoint for anemoi-datasets to PyEarthTools #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add entrypoint for anemoi-datasets to PyEarthTools #216
Conversation
Pull Request Test Coverage Report for Build 19430510647Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
Looks great, I have minor feedback only, let me know when it's ready to merge and I'll happily do so. Please take the feedback as suggestions only and just let me know when you are ready for me to merge it. |
tennlee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some suggestions. Let me know when you think it's ready. I don't have any objections to the merge, just things you might like to consider.
|
There are some very tiny issues with the docs, probably easiest if I just fix them up afterwards, as I can try a few things and test them locally. |
Co-authored-by: Tennessee Leeuwenburg <134973832+tennlee@users.noreply.github.com>
Add entrypoint for
anemoi.datasets.sourceto make use ofPyEarthToolspipelines.Allows for usage of
TODO @tennlee