Skip to content

ci(security): scope EIP-170 size gate to deployable contracts #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhfnetboy merged 2 commits into from
Jun 2, 2026
Merged

ci(security): scope EIP-170 size gate to deployable contracts #230

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed8b236
ci(security): scope EIP-170 gate to deployable contracts (skip test/s…
jhfnetboy Jun 1, 2026
4ca4cef
ci(security): use documented --skip test/script aliases (Codex review)
jhfnetboy Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/workflows/security.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,14 @@ jobs:
run: npm install -g solhint
- name: Solhint
run: solhint 'contracts/src/**/*.sol' || true # report-only until ruleset tuned
- name: Build + EIP-170 size
run: |
forge build --sizes
# Fail if SuperPaymaster exceeds the 24576-byte limit
forge build --sizes | awk '/SuperPaymaster /{ if ($0 ~ /[0-9]/) print }'
- name: Build + EIP-170 size (deployable contracts only)
# `forge build --sizes` exits non-zero if ANY built contract exceeds the 24576-byte
# EIP-170 limit. `test` and `script` are forge's documented --skip aliases for
# `.t.sol` / `.s.sol` (see `forge build --help`), so this scopes the gate to the
# contracts we actually deploy and is not tripped by test-only helpers — e.g.
# SuperPaymasterV2Reinit, a thin SuperPaymaster subclass used purely for UUPS
# reinitializer testing that is never deployed.
run: forge build --sizes --skip test --skip script

test:
name: Stage 2 — forge test + fuzz
Expand Down
Loading