Skip to content

Remove precomputed (cron-based) AAS Registry sync flow #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Remove precomputed (cron-based) AAS Registry sync flow #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9259f91
Initial plan
Copilot May 12, 2026
30b105b
Remove precomputed flow from DataEngine
Copilot May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
225 changes: 2 additions & 223 deletions ...DataEngine.UnitTests/ApplicationLogic/Services/AasRegistry/ShellDescriptorServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
using AAS.TwinEngine.DataEngine.ApplicationLogic.Exceptions.Application;
using AAS.TwinEngine.DataEngine.ApplicationLogic.Exceptions.Application;
using AAS.TwinEngine.DataEngine.ApplicationLogic.Exceptions.Infrastructure;
using AAS.TwinEngine.DataEngine.ApplicationLogic.Services.AasEnvironment.Providers;
using AAS.TwinEngine.DataEngine.ApplicationLogic.Services.AasRegistry;
using AAS.TwinEngine.DataEngine.ApplicationLogic.Services.AasRegistry.Providers;
using AAS.TwinEngine.DataEngine.ApplicationLogic.Services.Plugin;
using AAS.TwinEngine.DataEngine.DomainModel.AasRegistry;
using AAS.TwinEngine.DataEngine.DomainModel.Plugin;
Expand All @@ -22,12 +21,10 @@ public class ShellDescriptorServiceTests
private readonly ITemplateProvider _templateProvider = Substitute.For<ITemplateProvider>();
private readonly IPluginDataHandler _pluginDataHandler = Substitute.For<IPluginDataHandler>();
private readonly IShellDescriptorDataHandler _dataHandler = Substitute.For<IShellDescriptorDataHandler>();
private readonly IAasRegistryProvider _aasRegistryProvider = Substitute.For<IAasRegistryProvider>();
private readonly ILogger<ShellDescriptorService> _logger = Substitute.For<ILogger<ShellDescriptorService>>();
private readonly IPluginManifestConflictHandler _pluginManifestConflictHandler = Substitute.For<IPluginManifestConflictHandler>();
private readonly ShellDescriptorService _sut;

public ShellDescriptorServiceTests() => _sut = new ShellDescriptorService(_templateProvider, _dataHandler, _pluginDataHandler, _aasRegistryProvider, _logger, _pluginManifestConflictHandler);
public ShellDescriptorServiceTests() => _sut = new ShellDescriptorService(_templateProvider, _dataHandler, _pluginDataHandler, _pluginManifestConflictHandler);

[Fact]
public async Task GetAllShellDescriptorsAsync_ReturnsFilledShellDescriptors()
Expand Down Expand Up @@ -124,224 +121,6 @@ public async Task GetShellDescriptorByIdAsync_ReturnsFilledShellDescriptor()
Assert.Equal(expected, result);
}

[Fact]
public async Task SyncShellDescriptorsAsync_ShouldUpdate_ExistingDescriptors()
{
var filled = new List<ShellDescriptor>
{
new() { Id = "1" }
};
var existing = new ShellDescriptor { Id = "1" };
var metaData = new ShellDescriptorsMetaData
{
PagingMetaData = new PagingMetaData { Cursor = "nextCursor" },
ShellDescriptors = [new ShellDescriptorMetaData { Id = "1" }]
};

_aasRegistryProvider.GetAllAsync(Arg.Any<CancellationToken>()).Returns([existing]);
var manifests = new List<PluginManifest>
{
new()
{
PluginName = "TestPlugin",
PluginUrl = new Uri("http://test-plugin"),
SupportedSemanticIds = new List<string>(),
Capabilities = new Capabilities { HasShellDescriptor = true }
}
};
_pluginManifestConflictHandler.Manifests.Returns(manifests);
_pluginDataHandler.GetDataForAllShellDescriptorsAsync(null, null, manifests, Arg.Any<CancellationToken>()).Returns(metaData);
_dataHandler.FillOut(existing, metaData.ShellDescriptors).Returns(filled);

await _sut.SyncShellDescriptorsAsync(CancellationToken.None);

await _aasRegistryProvider.Received(1).PutAsync("1", null, Arg.Any<CancellationToken>());
await _aasRegistryProvider.DidNotReceive().CreateAsync(Arg.Any<ShellDescriptor>(), Arg.Any<CancellationToken>());
await _aasRegistryProvider.DidNotReceive().DeleteByIdAsync(Arg.Any<string>(), Arg.Any<CancellationToken>());
}

[Fact]
public async Task SyncShellDescriptorsAsync_ShouldCreate_NewDescriptors()
{
// Arrange
var metaData = new ShellDescriptorsMetaData
{
PagingMetaData = new PagingMetaData { Cursor = "nextCursor" },
ShellDescriptors = [new ShellDescriptorMetaData { Id = "2" }]
};
var template = new ShellDescriptor { Id = "template" };
var filled = new List<ShellDescriptor>
{
new() { Id = "2" }
};

_aasRegistryProvider.GetAllAsync(Arg.Any<CancellationToken>()).Returns([]);
var manifests = new List<PluginManifest>
{
new()
{
PluginName = "TestPlugin",
PluginUrl = new Uri("http://test-plugin"),
SupportedSemanticIds = new List<string>(),
Capabilities = new Capabilities { HasShellDescriptor = true }
}
};
_pluginManifestConflictHandler.Manifests.Returns(manifests);
_pluginDataHandler.GetDataForAllShellDescriptorsAsync(null, null, manifests, Arg.Any<CancellationToken>()).Returns(metaData);
_templateProvider.GetShellDescriptorsTemplateAsync(Arg.Any<CancellationToken>()).Returns(template);
_dataHandler.FillOut(template, metaData.ShellDescriptors).Returns(filled);

// Act
await _sut.SyncShellDescriptorsAsync(CancellationToken.None);

// Assert
await _aasRegistryProvider.Received(1).CreateAsync(Arg.Any<ShellDescriptor>(), Arg.Any<CancellationToken>());
}

[Fact]
public async Task SyncShellDescriptorsAsync_ShouldDelete_MissingDescriptors()
{
// Arrange
var existing = new ShellDescriptor { Id = "1" };
var metaData = new ShellDescriptorsMetaData
{
PagingMetaData = new PagingMetaData { Cursor = "nextCursor" },
ShellDescriptors = []
};
_aasRegistryProvider.GetAllAsync(Arg.Any<CancellationToken>()).Returns([existing]);
var manifests = new List<PluginManifest>
{
new()
{
PluginName = "TestPlugin",
PluginUrl = new Uri("http://test-plugin"),
SupportedSemanticIds = new List<string>(),
Capabilities = new Capabilities { HasShellDescriptor = true }
}
};
_pluginManifestConflictHandler.Manifests.Returns(manifests);
_pluginDataHandler.GetDataForAllShellDescriptorsAsync(null, null, manifests, Arg.Any<CancellationToken>()).Returns(metaData);

// Act
await _sut.SyncShellDescriptorsAsync(CancellationToken.None);

// Assert
await _aasRegistryProvider.Received(1).DeleteByIdAsync("1", Arg.Any<CancellationToken>());
}

[Fact]
public async Task SyncShellDescriptorsAsync_ShouldHandle_EmptyListsGracefully()
{
// Arrange
var metaData = new ShellDescriptorsMetaData
{
PagingMetaData = new PagingMetaData { Cursor = "nextCursor" },
ShellDescriptors = []
};
_aasRegistryProvider.GetAllAsync(Arg.Any<CancellationToken>())
.Returns([]);

_pluginDataHandler.GetDataForAllShellDescriptorsAsync(null, null, Arg.Any<IReadOnlyList<PluginManifest>>(), Arg.Any<CancellationToken>()).Returns(metaData);

// Act
var ex = await Record.ExceptionAsync(() => _sut.SyncShellDescriptorsAsync(CancellationToken.None));

// Assert
Assert.Null(ex);
await _aasRegistryProvider.DidNotReceive().CreateAsync(Arg.Any<ShellDescriptor>(), Arg.Any<CancellationToken>());
await _aasRegistryProvider.DidNotReceive().DeleteByIdAsync(Arg.Any<string>(), Arg.Any<CancellationToken>());
await _aasRegistryProvider.DidNotReceive().PutAsync(Arg.Any<string>(), Arg.Any<ShellDescriptor>(), Arg.Any<CancellationToken>());
}

[Fact]
public async Task SyncShellDescriptorsAsync_WhenRegistryDescriptorHasNoId_ShouldLogAndReturn()
{
var metaData = new ShellDescriptorsMetaData
{
PagingMetaData = new PagingMetaData(),
ShellDescriptors = [new ShellDescriptorMetaData { Id = "valid" }]
};

_aasRegistryProvider
.GetAllAsync(Arg.Any<CancellationToken>())
.Returns([new ShellDescriptor { Id = "" }]);

_pluginDataHandler
.GetDataForAllShellDescriptorsAsync(null, null, Arg.Any<IReadOnlyList<PluginManifest>>(), Arg.Any<CancellationToken>())
.Returns(metaData);

var exception = await Record.ExceptionAsync(
() => _sut.SyncShellDescriptorsAsync(CancellationToken.None));

Assert.Null(exception);

await _aasRegistryProvider
.DidNotReceive()
.CreateAsync(Arg.Any<ShellDescriptor>(), Arg.Any<CancellationToken>());
}

[Fact]
public async Task SyncShellDescriptorsAsync_WhenRegistryThrowsResourceNotFoundException_ShouldNotThrow()
{
_aasRegistryProvider
.GetAllAsync(Arg.Any<CancellationToken>())
.Throws(new ResourceNotFoundException());

var exception = await Record.ExceptionAsync(
() => _sut.SyncShellDescriptorsAsync(CancellationToken.None));

Assert.Null(exception);
}

[Fact]
public async Task SyncShellDescriptorsAsync_WhenRegistryThrowsResponseParsingException_ShouldNotThrow()
{
_aasRegistryProvider
.GetAllAsync(Arg.Any<CancellationToken>())
.Throws(new ResponseParsingException());

var exception = await Record.ExceptionAsync(
() => _sut.SyncShellDescriptorsAsync(CancellationToken.None));

Assert.Null(exception);
}

[Fact]
public async Task SyncShellDescriptorsAsync_WhenRegistryThrowsRequestTimeoutException_ShouldNotThrow()
{
_aasRegistryProvider
.GetAllAsync(Arg.Any<CancellationToken>())
.Throws(new RequestTimeoutException());

var exception = await Record.ExceptionAsync(
() => _sut.SyncShellDescriptorsAsync(CancellationToken.None));

Assert.Null(exception);
}

[Fact]
public async Task SyncShellDescriptorsAsync_WhenPluginMetadataHasNoId_ShouldLogAndReturn()
{
var metaData = new ShellDescriptorsMetaData
{
PagingMetaData = new PagingMetaData(),
ShellDescriptors = [new ShellDescriptorMetaData { Id = "" }]
};

_aasRegistryProvider
.GetAllAsync(Arg.Any<CancellationToken>())
.Returns([new ShellDescriptor { Id = "1" }]);

_pluginDataHandler
.GetDataForAllShellDescriptorsAsync(null, null, Arg.Any<IReadOnlyList<PluginManifest>>(), Arg.Any<CancellationToken>())
.Returns(metaData);

var exception = await Record.ExceptionAsync(
() => _sut.SyncShellDescriptorsAsync(CancellationToken.None));

Assert.Null(exception);
}

[Fact]
public async Task GetShellDescriptorByIdAsync_ShouldThrowException_WhenManifestConflict()
{
Expand Down
Loading
Loading