Open
Conversation
Resolves Agh-39
Author
|
This will require more work, but...I'm surprised this lib doesn't support this! Aborting requests is pretty important. @A, any clues as to the changes required to make this lib work with aborting? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of, but not all of, resolving gh-39
Superagent allows you to abort requests by using
req.abort(). The way this usually works is...superagent-mocker doesn't return
thisfrom its mockedend, so this adds that back in. However,req.abortdoesn't seem to be working, so I'm still investigating that.