Open
Conversation
mimwin
reviewed
Jan 20, 2022
| style={styles.image} | ||
| source={require('../../../asset/image/black50.png')}> | ||
| <View style={styles.topContainer}> | ||
| <Image onTouchEnd={() => { navigateTo.goBack() }} source={require('../../../asset/icon/backWhite.png')} /> |
0JIEUN0
requested changes
Jan 20, 2022
Member
0JIEUN0
left a comment
0JIEUN0
left a comment
There was a problem hiding this comment.
common component 를 잘 만들어두셔서 GroupDetailVoteScreen, GroupDetailSurveyScreen, GroupDetailResultScreen 동작이 깔끔하네요! 대신 data 빼고는 동작이 같아서 앞으로도 그렇다면 하나의 컴포넌트로 해도 괜찮겠다는 생각이 조금 들었습니다. 지금도 좋습니다~~!! 수고하셨어요!!👍👍
| <View style={styles.textContainer}> | ||
| <View style={{ marginRight: 28 }}> | ||
| <Text style={styles.font3}>소개</Text> | ||
| <Text style={styles.font3}>링크</Text> |
Member
There was a problem hiding this comment.
회의 내용에 따라, 링크 부분은 삭제해주시면 될 것 같아요!
Member
Author
저도 이게 약간 걸렸는데 하나의 화면으로하면 탭을 쓴 의미가 있을까? 싶어서 일단 나눠두긴 했어요
둘중에 선택하면 될 것 같습니다! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
상세내용
리뷰어가 확인할 사항
npm install해주세요!기타