Harden machine bridge and component pins#107
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a817989d62
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| current_bridge = run_json("abyss-machine", "bridge", "--json") | ||
| current_stack_bridge = run_json("abyss-machine", "stack-bridge", "export", "--json") | ||
| host_bridge = payload.get("host_bridge") if isinstance(payload.get("host_bridge"), dict) else {} |
There was a problem hiding this comment.
Warn when live bridge probes cannot be collected
If abyss-machine bridge --json or abyss-machine stack-bridge export --json fails (for example on an older or partially installed abyss-machine), run_json returns None and the subsequent comparisons are skipped, so warnings can remain zero and the script prints machine-bridge record current enough. That reports freshness as OK even though no live bridge state was available to compare, which can give operators a false readiness signal.
Useful? React with 👍 / 👎.
| machine = payload.get("machine") if isinstance(payload.get("machine"), dict) else {} | ||
| record_kernel = machine.get("kernel_release") | ||
| current_kernel = platform.release() | ||
| if isinstance(record_kernel, str) and record_kernel and record_kernel != current_kernel: |
There was a problem hiding this comment.
Require host identity fields before passing machine-fit freshness
The kernel/OS mismatch checks only run when machine.kernel_release and machine.os_version_id are present, but there is no warning when those fields are missing, so a record with fit_verdict.status=qualified and no host identity can still be reported as current enough. That undermines the new host-match gate because malformed or incomplete records can silently pass as fresh evidence.
Useful? React with 👍 / 👎.
Summary
Verification
Runtime Notes