[codex] durable federation user-unit selection#103
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2130bf1ffa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| local label="$1" | ||
| local value="$2" | ||
|
|
||
| [[ -n "$value" ]] || return 0 |
There was a problem hiding this comment.
Reject empty values for runtime-selection flags
aoa_validate_runtime_spec currently treats an empty selector as valid, so --preset= or --profile= passes validation and still writes 20-runtime-selection.conf with empty AOA_STACK_PRESET/AOA_STACK_PROFILE. In the new durable-selection flow, this can silently clear an intended selection (for example in automation when a variable expands to empty) and restart the unit into a different runtime shape than expected, including dropping federation-dependent services.
Useful? React with 👍 / 👎.
Summary
aoa-install-systemdruntime selection flags for--preset,--profile, repeated/comma selectors, and--restart-nowABYSS-STACK-Q-0009by preservingintel-fulland layeringfederationthrough one host-local user-unit drop-inRoot Cause
The live
langchain-apifederated consumer was enabled, but the systemd user unit restarted anintel-fullshape without thefederationprofile. That removedroute-apias outside the selected runtime. The repair keeps the checked-in unit generic and stores host-specific runtime selection in20-runtime-selection.conf.Validation
python scripts/validate_stack.pypython scripts/validate_nested_agents.pypython quests/scripts/build_quest_examples.py --checkpython -m pytest -q(263 passed, one upstream Python 3.14/Pydantic warning)bash -n scripts/aoa-install-systemd mechanics/runtime-lifecycle/parts/user-unit/aoa_install_systemd.shshellcheck -x scripts/aoa-install-systemd mechanics/runtime-lifecycle/parts/user-unit/aoa_install_systemd.shgit diff --checkaoa checkpoint review-note /home/dionysus/src/abyss-stack --commit-ref 2130bf1ffa2a944f5db8e11407e5d9d3bdc3704f --auto --root /srv/AbyssOSLive Verification
/srv/AbyssOS/abyss-stack/Configswithaoa-sync-configs --delete/srv/AbyssOS/abyss-stack/Configs/scripts/aoa-install-systemd --preset intel-full --profile federation --enable-now --restart-nowsystemctl --user cat podman-compose-abyss.serviceshowsAOA_STACK_PRESET=intel-fullandAOA_STACK_PROFILE=federationaoa-status --autonomy --jsonpasses route-api health, closure, federation layers, and has no degradation reasonsaoa-federated-check --require-enabledaoa-diagnose --preset intel-full --profile federation --truth-goal deployedexitsrunning_as_intendedafter cooldownSkipped