perf: inline base64 encode lookup in VLQ encoder#34
Open
7rulnik wants to merge 1 commit intopatch-0.6.1from
Open
perf: inline base64 encode lookup
in VLQ encoder#347rulnik wants to merge 1 commit intopatch-0.6.1from
7rulnik wants to merge 1 commit intopatch-0.6.1from
Conversation
Use direct string indexing instead of function call to base64.encode(). Avoids function call overhead and bounds check in hot serialization path. Benchmark shows ~8.5% serialization improvement (~19ms on 2.35M mappings). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Benchmarks
Command:
yarn bench