Skip to content

Fixed warning "Warning (bytecomp): reference to free variable 'log4slime-mode'". #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svetlyak40wt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed warning "Warning (bytecomp): reference to free variable 'log4slime-mode'". #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions elisp/log4slime.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,15 +746,6 @@ to the first log statement"
(goto-char next)))))))


(eval-after-load 'slime-repl
'(defadvice slime-repl-emit (around highlight-logging-category activate compile)
(with-current-buffer (slime-output-buffer)
(if log4slime-mode
(let ((start (marker-position slime-output-end)))
(setq ad-return-value ad-do-it)
(log4slime-highlight-log-message start (marker-position slime-output-end)))
(setq ad-return-value ad-do-it)))))

(defun log4slime-make-menubar-menu ()
(let ((C '(log4slime-check-connection)))
;; First level is dynamic
Expand Down Expand Up @@ -875,6 +866,17 @@ variable `log4slime-menu-levels'.
(when log4slime-mode
(log4slime-check-connection t)))


(eval-after-load 'slime-repl
'(defadvice slime-repl-emit (around highlight-logging-category activate compile)
(with-current-buffer (slime-output-buffer)
(if log4slime-mode
(let ((start (marker-position slime-output-end)))
(setq ad-return-value ad-do-it)
(log4slime-highlight-log-message start (marker-position slime-output-end)))
(setq ad-return-value ad-do-it)))))


(defun log4slime-redefine-menus (&optional global)
"Redefine log4slime menus. If GLOBAL is true, make dropdown menu
global instead of local to files with `log4slime-mode' active"
Expand Down