Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/composekit/generate.py
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ def main(args: argparse.Namespace) -> None:
if name in used_names:
number = str(used_names.count(name) + 1)
container["name"] = name = f"{name}_{number}"
if container["folder"]:
if container.get("folder"):
container["folder"] += number

used_names.append(name)
Expand Down
32 changes: 32 additions & 0 deletions tests/test_generate.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
import argparse
import tempfile
import unittest
from pathlib import Path
from typing import Any
from unittest.mock import MagicMock

import yaml

from composekit.generate import (
Config,
capitalize_name,
Expand All @@ -10,6 +15,7 @@
get_folder_name,
handle_volumes,
is_custom_bind,
main,
)


Expand Down Expand Up @@ -84,6 +90,32 @@ def test_generate_minimal(self) -> None:
self.assertEqual(result["restart"], "unless-stopped")
self.assertEqual(result["networks"], ["cloud"])

def test_main_handles_duplicate_containers_without_folder(self) -> None:
with tempfile.TemporaryDirectory() as directory:
root = Path(directory)
containers = root / "containers"
composes = root / "composes"
output = root / "docker-compose.yaml"
containers.mkdir()
(containers / "container.yaml").write_text(
"image: nginx\n---\nimage: redis\n"
)

args = argparse.Namespace(
config=None,
containers=str(containers),
composes=str(composes),
output=str(output),
commit=False,
)

main(args)

compose = yaml.safe_load((composes / "container.yaml").read_text())
self.assertEqual(
list(compose["services"].keys()), ["container", "container_2"]
)

def test_handle_volumes_with_full_capitalize(self) -> None:
config = Config()
config["bind_path"] = "${BIND_PATH}"
Expand Down