Skip to content

Set header based on the URL instead of setting it on every request #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chandramouleswaran wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set header based on the URL instead of setting it on every request #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions _locales/en/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@
"headers_value": {
"message": "Value"
},
"headers_pattern": {
"message": "URL Pattern"
},
"headers_active": {
"message": "Active"
},
Expand Down
4 changes: 2 additions & 2 deletions manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"manifest_version": 2,
"name": "Header-Editor",
"name": "Header Editor",
"description": "Alter your HTTP request headers on the fly",
"version": "2.2.0",
"version": "2.3.0",
"default_locale": "en",

"options_page": "/src/html/options.html",
Expand Down
4 changes: 4 additions & 0 deletions src/html/options.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ <h2 data-text="request_title"></h2>
<th data-text="headers_description"></th>
<th data-text="headers_header"></th>
<th data-text="headers_value"></th>
<th data-text="headers_pattern"></th>
<th data-text="headers_active"></th>
<th></th>
</tr>
Expand All @@ -46,6 +47,7 @@ <h2 data-text="request_title"></h2>
<td><label><input type="text" class="options-headers-create-description" /></label></td>
<td><label><input type="text" class="options-headers-create-header" /></label></td>
<td><label><input type="text" class="options-headers-create-value" /></label></td>
<td><label><input type="text" class="options-headers-create-pattern" value=".*" /></label></td>
<td><label><input type="checkbox" class="options-headers-create-active" checked="true" /></label></td>
<td><button class="options-headers-create-add" data-text="headers_add"></button></td>
</tr>
Expand All @@ -65,6 +67,7 @@ <h2 data-text="response_title"></h2>
<th data-text="headers_description"></th>
<th data-text="headers_header"></th>
<th data-text="headers_value"></th>
<th data-text="headers_pattern"></th>
<th data-text="headers_active"></th>
<th></th>
</tr>
Expand All @@ -74,6 +77,7 @@ <h2 data-text="response_title"></h2>
<td><label><input type="text" class="options-headers-create-description" /></label></td>
<td><label><input type="text" class="options-headers-create-header" /></label></td>
<td><label><input type="text" class="options-headers-create-value" /></label></td>
<td><label><input type="text" class="options-headers-create-pattern" /></label></td>
<td><label><input type="checkbox" class="options-headers-create-active" checked="true" /></label></td>
<td><button class="options-headers-create-add" data-text="headers_add"></button></td> </tr>
<tr><td colspan="5"><hr /></td></tr>
Expand Down
11 changes: 6 additions & 5 deletions src/js/background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@

(function() {
var transformHeaders = function(headers) {
var transformHeaders = function(headers, details) {
// [ { name: "", value: "" } ]
var list = [];

for (var i = 0; i < headers.length; i++) {
var header = headers[i];

if (header.active) {

var isMatching = details.url.match(header.pattern);
if (header.active && isMatching) {
list.push({
name: header.header,
value: header.value
Expand Down Expand Up @@ -36,7 +37,7 @@
var EXTRAS = ["requestHeaders", "blocking"];

var modify = function(details) {
details.requestHeaders = details.requestHeaders.concat(transformHeaders(getHeaders(/^backbone\.requestHeaders.+$/)));
details.requestHeaders = details.requestHeaders.concat(transformHeaders(getHeaders(/^backbone\.requestHeaders.+$/), details));

return { requestHeaders: details.requestHeaders };
};
Expand All @@ -50,7 +51,7 @@
var EXTRAS = ["responseHeaders", "blocking"];

var modify = function(details) {
details.responseHeaders = details.responseHeaders.concat(transformHeaders(getHeaders(/^backbone\.responseHeaders.+$/)));
details.responseHeaders = details.responseHeaders.concat(transformHeaders(getHeaders(/^backbone\.responseHeaders.+$/), details));

return { responseHeaders: details.responseHeaders };
};
Expand Down
11 changes: 11 additions & 0 deletions src/js/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ var HeaderSDK = {
description: "",
header: "",
value: "",
pattern: ".*",
active: true
};
}
Expand Down Expand Up @@ -70,6 +71,15 @@ var HeaderSDK = {
.val(this.model.get("value"))
.addClass("options-header-input"))
.addClass("options-header-cell");

var $patternCell = $(document.createElement("td"))
.append(this.model.get("pattern"))
.append($(document.createElement("input"))
.attr("type", "text")
.attr("name", "pattern")
.val(this.model.get("pattern"))
.addClass("options-header-input"))
.addClass("options-header-cell");

var $activeCell = $(document.createElement("td"))
.append($(document.createElement("input"))
Expand All @@ -91,6 +101,7 @@ var HeaderSDK = {
this.$el.append($descriptionCell);
this.$el.append($headerCell);
this.$el.append($valueCell);
this.$el.append($patternCell);
this.$el.append($activeCell);
this.$el.append($actionCell);

Expand Down
3 changes: 3 additions & 0 deletions src/js/options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
this.$createDescription = this.$el.find(".options-headers-create-description");
this.$createHeader = this.$el.find(".options-headers-create-header");
this.$createValue = this.$el.find(".options-headers-create-value");
this.$createPattern = this.$el.find(".options-headers-create-pattern");
this.$createActive = this.$el.find(".options-headers-create-active");

this.listenTo(this.headers, "add", this.renderSingle);
Expand All @@ -74,12 +75,14 @@
description: this.$createDescription.val(),
header: this.$createHeader.val(),
value: this.$createValue.val(),
pattern: this.$createPattern.val(),
active: this.$createActive.is(":checked")
});

this.$createDescription.val("");
this.$createHeader.val("");
this.$createValue.val("");
this.$createPattern.val(".*");
this.$createActive.prop("checked", true);
}
});
Expand Down
34 changes: 34 additions & 0 deletions src/js/upgrade.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,36 @@
}
}

// Methods for updating pattern matching
function update_2_3_0() {
function updateHeaders(headerKeys, headerPrefix) {
console.log(headerKeys);

for (var i = 0; i < headerKeys.length; i++) {
var headerKey = headerPrefix + headerKeys[i];
var header = JSON.parse(localStorage.getItem(headerKey));

console.log(headerPrefix, headerKey);

// Create the new header field if one does not exist
header.pattern = header.pattern || ".*";

localStorage.setItem(headerKey, JSON.stringify(header));
}
}

var requestHeaders = localStorage.getItem("backbone.requestHeaders");
var responseHeaders = localStorage.getItem("backbone.requestHeaders");

if (!!requestHeaders) {
updateHeaders(requestHeaders.split(","), "backbone.requestHeaders-");
}

if (!!responseHeaders) {
updateHeaders(responseHeaders.split(","), "backbone.responseHeaders-");
}
}

chrome.runtime.onInstalled.addListener(function(details) {
var previousVersion = details.previousVersion;
var currentVersion = chrome.app.getDetails().version;
Expand All @@ -131,6 +161,10 @@
if (0 > compareVersions(previousVersion, "2.2.0")) {
update_2_2_0();
}

if (0 > compareVersions(previousVersion, "2.3.0")) {
update_2_3_0();
}
}
});
})();
Expand Down