[2/n] Clean up logs with typescript projects #3077
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using jj-spr 0.1.0
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // Collapse multiple spaces | ||
| let re = Regex::new(r"\s+").unwrap(); | ||
| re.replace_all(&without_newlines, " ").trim().to_string() | ||
| } |
There was a problem hiding this comment.
Bug: Regex compiled on every log message call
The sanitize_message function creates a new Regex object via Regex::new(r"\s+") on every invocation. Since this function is called for every log message in both text and JSON formatters, regex compilation happens on every single log call. Regex compilation is expensive. The regex pattern is constant and could be compiled once using lazy_static! or std::sync::LazyLock and reused, which the codebase already does elsewhere.
LucioFranco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Sanitizes all log messages to single-line, normalized whitespace and removes emojis from runtime logs; updates docs and adds tests.
sanitize_messageto strip newlines and collapse whitespace; applied in legacyTextFormatterandJsonFormattersomessageis sanitized before output.DirectWriteVisitor; switch toMessageVisitor+ sanitization.spawn_webapp_update_listenerand Kafka shutdown messages inshutdown.Written by Cursor Bugbot for commit 024836c. This will update automatically on new commits. Configure here.