Feature: new ignore operation: LowCardinality(String) vs String #3049
+752
−68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Co-Authored-By: Claude noreply@anthropic.com
Note
Adds an ignorable operation to treat LowCardinality(String) and String as equivalent during diffs, wiring it through comparisons/normalization and adding comprehensive tests.
compute_table_columns_diffandcolumns_are_equivalentto acceptignore_ops, honoringIgnoreStringLowCardinalityDifferences.&[]default.ignore_low_cardinalitytocolumn_types_are_equivalent,json_options_are_equivalent, andnested_are_equivalent.normalize_column_for_low_cardinality_ignoreto stripLowCardinalityannotations when ignoring.IgnorableOperation::IgnoreStringLowCardinalityDifferencesand handle it innormalize_table_for_diffto stripLowCardinalityannotations.compute_table_columns_diff(.., &[]).Written by Cursor Bugbot for commit 0109f4e. This will update automatically on new commits. Configure here.