Skip to content

Fix fetching the correct sort field for relations #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kskaiser wants to merge 1 commit into
base: main-cris
Choose a base branch
from
+5 −2
Open

Fix fetching the correct sort field for relations #548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .../src/main/java/org/dspace/discovery/configuration/DiscoveryConfigurationUtilsService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import org.dspace.core.Context;
import org.dspace.discovery.DiscoverQuery;
import org.dspace.discovery.DiscoverResultIterator;
import org.dspace.discovery.SearchService;
import org.dspace.discovery.indexobject.IndexableItem;
import org.springframework.beans.factory.annotation.Autowired;

Expand All @@ -34,6 +35,8 @@ public class DiscoveryConfigurationUtilsService {
private ItemService itemService;
@Autowired
private DiscoveryConfigurationService searchConfigurationService;
@Autowired
private SearchService solrService;

public Iterator<Item> findByRelation(Context context, Item item, String relationName) {
String entityType = itemService.getMetadataFirstValue(item, "dspace", "entity", "type", Item.ANY);
Expand Down Expand Up @@ -61,7 +64,7 @@ public Iterator<Item> findByRelation(Context context, Item item, String relation
} else {
DiscoverySortFieldConfiguration sortField =
discoveryConfiguration.getSearchSortConfiguration().getDefaultSortField();
discoverQuery.setSortField(sortField.getMetadataField(),
discoverQuery.setSortField(solrService.toSortFieldIndex(sortField.getMetadataField(), sortField.getType()),
DiscoverQuery.SORT_ORDER.valueOf(sortField.getDefaultSortOrder().name()));
}

Expand All @@ -78,4 +81,4 @@ private DiscoveryConfiguration findDiscoveryConfiguration(String entityType, Str
return searchConfigurationService.getDiscoveryConfigurationByName(configurationName);
}

}
}