feat(Standard-Compositions): Imported standard metal fractions from MESA#10
Open
poojanagrawal wants to merge 7 commits into
Open
feat(Standard-Compositions): Imported standard metal fractions from MESA#10poojanagrawal wants to merge 7 commits into
poojanagrawal wants to merge 7 commits into
Conversation
Imported standard metal fractions from MESA to build compositions from one of the standard schemes
Added additional overloads to allow typesafe and compile time checking of requested composition
also added docs
Added first basic unit test to ensure all standard solar compositions can load. Not currently passing
Moved the abundance calculations to its own function instead of main, fixed calulations of mass fractions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imported standard metal fractions from MESA to build compositions from one of the standard schemes