Feature/exclude basemaps from single wms#685
Merged
rldhont merged 6 commits into3liz:masterfrom Feb 4, 2026
Merged
Conversation
Adds a new configuration option 'exclude_basemaps_from_single_wms' that allows users to control whether basemaps are included in the single WMS request when wms_single_request_for_all_layers is enabled. When enabled, this improves performance for Cloud-Optimized GeoTIFF (COG) basemaps by preserving their native format instead of converting to PNG. Disabled by default for backward compatibility.
Fixes two bugs in LwcVersions class that were discovered during development: - Add missing return statement in LwcVersions.oldest() method - Fix LwcVersions.find() call in version_checker.py by removing the is_dev parameter (method signature was changed but call site wasn't updated) Also updates .gitignore to exclude all .zip files, not just lizmap.*.zip pattern.
When no server is configured, current_lwc_version() returns None, which causes TypeErrors when comparing with LwcVersions enum values. Default to LwcVersions.latest() when no version is available, which ensures the plugin uses the most recent feature set when no server is configured yet.
The 'Exclude basemaps from single WMS' checkbox is now disabled (greyed out) when the 'Load layers as single WMS layer' option is not checked, since it only has meaning when single WMS is enabled.
Collaborator
Author
|
|
Resolve merge conflict in plugin.py
Test checkbox states and config output for the new option.
Collaborator
Author
|
nice! I rebased and added the following tests, hope they are sufficient!
|
Contributor
|
Thanks @meyerlor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the basemap exclusion behavior configurable via the new exclude_basemaps_from_single_wms plugin option, addressing feedback from 3liz/lizmap-web-client#6351 (comment)
Changes:
Previously, basemaps were unconditionally excluded from single WMS requests. Now users can control this behavior:
Backward compatibility:
The option defaults to false, maintaining existing behavior for projects that don't explicitly enable it.
Technical details: