Skip to content

feat(#635): Support isExpanded on KtDrawer#641

Open
carsoli wants to merge 3 commits intomasterfrom
635-support-is-expanded-on-kt-drawer
Open

feat(#635): Support isExpanded on KtDrawer#641
carsoli wants to merge 3 commits intomasterfrom
635-support-is-expanded-on-kt-drawer

Conversation

@carsoli
Copy link
Copy Markdown
Contributor

@carsoli carsoli commented Jun 23, 2022

No description provided.

@render
Copy link
Copy Markdown

render bot commented Jun 23, 2022

@github-actions github-actions bot added the package:kotti-ui @3yourmind/kotti-ui label Jun 23, 2022
@carsoli carsoli added type:enhancement features, etc. priority:3-normal Should be fixed soon autorebase:opt-in Apply this label to enable automatic rebasing labels Jun 23, 2022
@carsoli carsoli force-pushed the 635-support-is-expanded-on-kt-drawer branch from 09cb5de to b20fff7 Compare June 23, 2022 15:09
@FlorianWendelborn FlorianWendelborn force-pushed the 635-support-is-expanded-on-kt-drawer branch 6 times, most recently from 88765af to 015da93 Compare June 24, 2022 12:29
@FlorianWendelborn FlorianWendelborn force-pushed the 635-support-is-expanded-on-kt-drawer branch from 015da93 to cf976e5 Compare June 27, 2022 14:03
@carsoli carsoli force-pushed the 635-support-is-expanded-on-kt-drawer branch from cf976e5 to 015da93 Compare June 27, 2022 14:03
@FlorianWendelborn FlorianWendelborn force-pushed the 635-support-is-expanded-on-kt-drawer branch 3 times, most recently from cb1c39d to b9ad6d9 Compare June 28, 2022 17:06
@FlorianWendelborn FlorianWendelborn added the autorebase:non-rebaseable AutoRebase applies this label when a pull request can't be rebased automatically label Jun 28, 2022
Comment thread packages/documentation/package.json Outdated
// Utility classes
@import 'utilities';
@import 'media';
@import 'mixins';
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure, but this looks like a no-op.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i moved it under kotti-style, so

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FlorianWendelborn can this be resolved?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seems like a noop

Copy link
Copy Markdown
Contributor Author

@carsoli carsoli Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you either elaborate on why you think it is or test it?

@carsoli carsoli changed the title 635: Support isExpanded on KtDrawer feat(635): Support isExpanded on KtDrawer Jul 25, 2022
@carsoli carsoli force-pushed the 635-support-is-expanded-on-kt-drawer branch from b9ad6d9 to 3dcd403 Compare July 25, 2022 11:28
@FlorianWendelborn FlorianWendelborn removed the autorebase:non-rebaseable AutoRebase applies this label when a pull request can't be rebased automatically label Jul 25, 2022
@FlorianWendelborn FlorianWendelborn force-pushed the 635-support-is-expanded-on-kt-drawer branch 2 times, most recently from 1c48fdc to 3a898f6 Compare October 14, 2022 13:36
@FlorianWendelborn FlorianWendelborn force-pushed the 635-support-is-expanded-on-kt-drawer branch 5 times, most recently from 1178f95 to bc552ab Compare November 29, 2022 11:28
@FlorianWendelborn FlorianWendelborn force-pushed the 635-support-is-expanded-on-kt-drawer branch 5 times, most recently from 41bfafa to 18c0352 Compare December 9, 2022 14:27
@FlorianWendelborn FlorianWendelborn force-pushed the 635-support-is-expanded-on-kt-drawer branch 3 times, most recently from 86d32b9 to 8a79034 Compare December 14, 2022 11:05
@FlorianWendelborn FlorianWendelborn force-pushed the 635-support-is-expanded-on-kt-drawer branch from 8a79034 to 2285841 Compare December 19, 2022 15:09
@FlorianWendelborn FlorianWendelborn force-pushed the 635-support-is-expanded-on-kt-drawer branch 2 times, most recently from c075a6c to ca86592 Compare December 30, 2022 01:18
@carsoli carsoli changed the title feat(635): Support isExpanded on KtDrawer feat(#635): Support isExpanded on KtDrawer Feb 1, 2023
@carsoli carsoli force-pushed the 635-support-is-expanded-on-kt-drawer branch from ca86592 to 7adaca5 Compare February 1, 2023 10:53
@FlorianWendelborn FlorianWendelborn added the autorebase:non-rebaseable AutoRebase applies this label when a pull request can't be rebased automatically label Aug 22, 2023
@Isokaeder Isokaeder force-pushed the master branch 4 times, most recently from c23cd01 to ecc7eba Compare May 14, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autorebase:non-rebaseable AutoRebase applies this label when a pull request can't be rebased automatically autorebase:opt-in Apply this label to enable automatic rebasing package:kotti-ui @3yourmind/kotti-ui priority:3-normal Should be fixed soon type:enhancement features, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants