Refactor/shape#141
Open
chemiskyy wants to merge 5 commits into
Open
Conversation
Make Shape.generate_surface_mesh polymorphic for Box, Sphere and Spinodoid by accepting optional bounds/resolution and falling back to the SDF/marching-cubes path when callers request explicit sampling. Add BoundsType imports and update docstrings to explain the behavior. Remove the legacy rotate_pv_euler function and its export from operations/__init__ (cleanup of Euler helper). Tidy Rve by removing unused is_matrix/matrix_number defaults. Expose new TPMS-related classes (GradedInfill, Sweep) in shape exports and update __all__ accordingly. Add a lint test (tests/test_no_top_level_ocp_imports.py) to prevent top-level OCP imports outside the CAD boundary.
Make Rve a frozen dataclass with validated inputs and explicit pbc flags. Introduce helper validators, cached min_point/max_point and a cached box property (lazy CAD box creation). Add Rve.grid(...) to produce a pyvista.StructuredGrid with flexible resolution handling. Improve __repr__ and update from_min_max to accept pbc. Expand tests to cover pbc behavior, immutability, min/max consistency, grid generation, invalid inputs, and repr content.
Introduce shared shape type aliases and an intrinsic period attribute, and add a generic CAD bridge and periodic-shell sewing. - Add microgen/shape/_types.py with Field, BoundsType and PeriodType aliases to centralize type defs. - Add microgen/shape/periodic_shell.py: mesh_to_periodic_shell builds sewn OCCT shells with planar cap faces for periodic meshes. - Add shape_to_cad in microgen/cad.py: generic fallback to build a tessellated CadShape from an implicit Shape. - Update microgen/shape/shape.py: import shared types, add Shape.period property, and delegate default generate_cad to shape_to_cad. - Update Tpms and Spinodoid to set their intrinsic _period and reuse mesh_to_periodic_shell; remove duplicated periodic-sewing code. - Add tests/tests_shapes/test_shape_period.py to verify period behavior and periodicity for Tpms/Spinodoid. These changes centralize type annotations, avoid duplicated sewing logic, and expose intrinsic periodicity as a data-structure invariant used by TPMS/Spinodoid shapes. The periodic shell code requires the optional CAD backend.
Replace the single monolithic microgen/cad.py with a microgen.cad subpackage. The functionality has been split across new modules: __init__.py, _install.py, io.py, meshbridge.py, primitives.py, shape.py and topo.py to isolate responsibilities and enable lazy OCP imports (OCP remains an optional dependency). Tests were updated to reflect the package layout (no top-level OCP import). This reorganization improves maintainability and ensures import-time safety when OCP is not installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and new features to the
microgenpackage, focusing on enhanced support for implicit shapes, periodic geometry, and improved type safety and API consistency. The most significant changes include the addition of a robust, immutableRve(Representative Volume Element) class, a new utility for sewing periodic triangle meshes into closed CAD shells, and improved type definitions for implicit shape operations. There are also API cleanups, such as the removal of unused rotation utilities and the addition of new shape types.New features and enhancements:
Rveclass inmicrogen/rve.py, providing a more robust and type-safe container for RVE geometry, periodicity flags, and structured grid generation. This replaces the previous mutable class and adds validation and convenience methods. [1] [2]mesh_to_periodic_shellinmicrogen/shape/periodic_shell.py, a utility that sews periodic triangulated surfaces into closed OCCT shells, supporting periodic TPMS and spinodoid shapes.shape_to_cadinmicrogen/cad.py, a generic bridge for converting implicitShapeinstances to CAD BREP using surface meshing, improving support for arbitrary implicit shapes.microgen/shape/_types.pywith shared type aliases (Field,BoundsType,PeriodType) for implicit shape operations, centralizing definitions and improving type safety across the codebase.API changes and cleanups:
rotate_pv_eulerfunction and its exports from the codebase for clarity and to avoid confusion. [1] [2] [3]Box.generate_surface_meshto support explicitboundsandresolutionparameters, falling back to the base implementation when these are provided for polymorphic compatibility.GradedInfill,Sweep) to the public API and import lists, making them available for downstream use. [1] [2] [3] [4] F1f9f521L21R21, [5] [6]Internal improvements:
These changes collectively improve the flexibility, correctness, and maintainability of the
microgenpackage, especially for advanced use cases involving implicit and periodic geometry.