Enforce FBT001/FBT002 and N802 ruff rules#135
Closed
kmarchais wants to merge 1 commit into
Closed
Conversation
ff402d9 to
0e1c101
Compare
0e1c101 to
62cdf87
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Locks in ruff enforcement of the boolean-trap rules (FBT001/FBT002) and lowercase-function-name rule (N802). N802 was already satisfied by #134; this PR adds it to
extend-selectso future violations fail CI. FBT requires two*insertions to mark booleans as kw-only.Changes
pyproject.toml—extend-select = ["FBT001", "FBT002", "N802"]microgen/shape/strut_lattice/abstract_lattice.py—*beforecell_size/strut_joints/densityinAbstractLattice.__init__microgen/shape/strut_lattice/custom_lattice.py—*before strut-related kwargs inCustomLattice.__init__; stale# noqa: PLR0913removed