some simplifications suggested by ruff#59
Open
fchapoton wants to merge 1 commit into3-manifolds:masterfrom
Open
some simplifications suggested by ruff#59fchapoton wants to merge 1 commit into3-manifolds:masterfrom
fchapoton wants to merge 1 commit into3-manifolds:masterfrom
Conversation
Member
|
Are the suggested type hints supported by all versions of Python that we support? |
Contributor
Author
|
ah, good question indeed. What is the oldest python you support ? |
Contributor
Author
|
I have undone the "-> list" annotation, that indeed requires a somewhat recent python. Some "-> bool" annotations were already present in the code, so I kept the new ones. |
Contributor
Author
|
the annotation "-> bool" is accepted since at least python 3.5 |
Contributor
Author
|
@culler This should be good to go now. |
Contributor
Author
|
ping ? |
Contributor
Author
|
@NathanDunfield : I am a bit sad to see my pull requests being neglected. I am just trying to help a little bit by doing basic house-cleaning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using the code RET, so mainly about the return in methods and functions